gogrlx/bitcask
1
0
Fork 0
mirror of https://github.com/gogrlx/bitcask.git synced 2026-04-02 02:58:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

Replace keydir with ART trie (#75)

Browse Source 
* Replace keydir with ART trie

* Address some review feedback

* Address review feedback (consts)
This commit is contained in:
James Mills
2019-09-02 08:38:56 +10:00
committed by GitHub
parent 36bc134b22
commit abbbeb8e1d
8 changed files with 201 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
options.go
View File

@@ -25,7 +25,6 @@ type config struct {
maxKeySize int
maxValueSize int
sync bool
greedyScan bool
}
func (c *config) MarshalJSON() ([]byte, error) {
@@ -34,13 +33,11 @@ func (c *config) MarshalJSON() ([]byte, error) {
MaxKeySize int `json:"max_key_size"`
MaxValueSize int `json:"max_value_size"`
Sync bool `json:"sync"`
GreedyScan bool `json:"greedy_scan"`
}{
MaxDatafileSize: c.maxDatafileSize,
MaxKeySize: c.maxKeySize,
MaxValueSize: c.maxValueSize,
Sync: c.sync,
GreedyScan: c.greedyScan,
})
}
@@ -50,7 +47,6 @@ func getConfig(path string) (*config, error) {
MaxKeySize int `json:"max_key_size"`
MaxValueSize int `json:"max_value_size"`
Sync bool `json:"sync"`
GreedyScan bool `json:"greedy_scan"`
}
var cfg Config
@@ -69,7 +65,6 @@ func getConfig(path string) (*config, error) {
maxKeySize: cfg.MaxKeySize,
maxValueSize: cfg.MaxValueSize,
sync: cfg.Sync,
greedyScan: cfg.GreedyScan,
}, nil
}
@@ -113,12 +108,3 @@ func WithSync(sync bool) Option {
return nil
}
}
// WithGreedyScan enables faster Scan performance.
// This is disabled by default because it causes high memory usage.
func WithGreedyScan(enabled bool) Option {
return func(cfg *config) error {
cfg.greedyScan = enabled
return nil
}
}