From 1492cf717fa57d1eab4134b830402602deb6ead7 Mon Sep 17 00:00:00 2001
From: Waldemar Quevedo <wally@nats.io>
Date: Tue, 8 Aug 2023 16:41:10 -0700
Subject: [PATCH] test: fix TestFileStoreNewWriteIndexInfo hanging

t.Fatalf being called while holding a lock would
sometimes leave builds hanging.

Signed-off-by: Waldemar Quevedo <wally@nats.io>
---
 server/filestore_test.go | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/server/filestore_test.go b/server/filestore_test.go
index f4a3d57a..bedc60ce 100644
--- a/server/filestore_test.go
+++ b/server/filestore_test.go
@@ -5478,9 +5478,16 @@ func TestFileStoreNewWriteIndexInfo(t *testing.T) {
 
 		mb.mu.Lock()
 		start := time.Now()
-		require_NoError(t, mb.writeIndexInfoLocked())
+		err = mb.writeIndexInfoLocked()
+		if err != nil {
+			mb.mu.Unlock()
+			t.Fatalf("Unexpected error: %v", err)
+		}
 		elapsed := time.Since(start)
-		require_True(t, elapsed < time.Millisecond)
+		if elapsed > time.Millisecond {
+			mb.mu.Unlock()
+			t.Fatalf("Unexpected elapsed time: %v", elapsed)
+		}
 		fi, err := os.Stat(mb.ifn)
 		mb.mu.Unlock()