gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove global logger

Browse Source 
gnatsd currently uses a global logger. This can cause some problems
(especially around the config-reload work), but global variables are
also just an anti-pattern in general. The current behavior is
particularly surprising because the global logger is configured through
calls to the Server.

This addresses issue #500 by removing the global logger and making it a
field on Server.
This commit is contained in:
Tyler Treat
2017-05-31 16:06:31 -05:00
parent d6069447d2
commit 28160f1de2
11 changed files with 119 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/split_test.go
View File

@@ -288,7 +288,8 @@ func TestSplitConnectArg(t *testing.T) {
}
func TestSplitDanglingArgBuf(t *testing.T) {
c := &client{subs: make(map[string]*subscription)}
s := New(&defaultServerOptions)
c := &client{srv: s, subs: make(map[string]*subscription)}
// We test to make sure we do not dangle any argBufs after processing
// since that could lead to performance issues.