From 2ac72d92bfe7ce33389693f132aedc9979f5f82c Mon Sep 17 00:00:00 2001 From: Phil Pennock Date: Tue, 7 Feb 2023 17:32:20 -0500 Subject: [PATCH] YAML engineering: quote go version string We're currently using Go 1.19; we'll switch to 1.20 when the NATS Maintainers make the call to switch. Prepare by making sure that 1.20 won't turn into 1.2 instead, by quoting the string to be updated and adding a warning. --- .github/workflows/go-test.yaml | 4 +++- .github/workflows/nightly.yaml | 4 +++- .travis.yml | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/go-test.yaml b/.github/workflows/go-test.yaml index bac6c719..97e69808 100644 --- a/.github/workflows/go-test.yaml +++ b/.github/workflows/go-test.yaml @@ -5,7 +5,9 @@ jobs: test: strategy: matrix: - go: [1.16] + # This should be quoted or use .x, but should not be unquoted. + # Remember that a YAML bare float drops trailing zeroes. + go: ['1.16'] env: GOPATH: /home/runner/work/nats-server diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index 8944880c..2928cfdc 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -24,7 +24,9 @@ jobs: - name: Set up Go uses: actions/setup-go@v3 with: - go-version: 1.19 + # This should be quoted or use .x, but should not be unquoted. + # Remember that a YAML bare float drops trailing zeroes. + go-version: '1.19' - name: goreleaser uses: goreleaser/goreleaser-action@v3 diff --git a/.travis.yml b/.travis.yml index 06b876eb..b978f110 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,9 @@ vm: language: go go: -- 1.19.5 +# This should be quoted or use .x, but should not be unquoted. +# Remember that a YAML bare float drops trailing zeroes. +- '1.19.5' addons: apt: