From 746b44a0201bb080c3e1180813e939a6fdf652c3 Mon Sep 17 00:00:00 2001 From: Ivan Kozlovic Date: Thu, 28 Jul 2022 17:58:25 -0600 Subject: [PATCH] Fixed TLS test so it passes on macOS Signed-off-by: Ivan Kozlovic --- server/leafnode_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/leafnode_test.go b/server/leafnode_test.go index e14d8fab..ac26e88f 100644 --- a/server/leafnode_test.go +++ b/server/leafnode_test.go @@ -2624,7 +2624,11 @@ func TestLeafNodeTLSConfigReload(t *testing.T) { // Wait for the error select { case err := <-lg.errCh: - if !strings.Contains(err, "unknown") && !strings.Contains(err, "broken") { + // Since Go 1.18, we had to regenerate certs to not have to use GODEBUG="x509sha1=1" + // But on macOS, with our test CA certs, no SCTs included, it will fail + // for the reason "x509: “localhost” certificate is not standards compliant" + // instead of "unknown authority". + if !strings.Contains(err, "unknown") && !strings.Contains(err, "compliant") { t.Fatalf("Unexpected error: %v", err) } case <-time.After(2 * time.Second):