From 84d37e8a929d120e86f1d7fa18bba14ac90e574c Mon Sep 17 00:00:00 2001 From: scottf Date: Tue, 10 Aug 2021 17:38:46 -0400 Subject: [PATCH] assign default to MaxAckPending when AckExplicit -or- AckAll, not just AckExplicit --- server/consumer.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/consumer.go b/server/consumer.go index 68058dad..e9ad5543 100644 --- a/server/consumer.go +++ b/server/consumer.go @@ -351,7 +351,7 @@ func (mset *stream) addConsumerWithAssignment(config *ConsumerConfig, oname stri config.MaxDeliver = -1 } // Set proper default for max ack pending if we are ack explicit and none has been set. - if config.AckPolicy == AckExplicit && config.MaxAckPending == 0 { + if (config.AckPolicy == AckExplicit || config.AckPolicy == AckAll) && config.MaxAckPending == 0 { config.MaxAckPending = JsDefaultMaxAckPending }