From a4833d0889e5e1a9b2b96e64f15127f05ef2cea9 Mon Sep 17 00:00:00 2001 From: Waldemar Quevedo Date: Thu, 13 Apr 2023 14:57:04 -0700 Subject: [PATCH] Fix raft log debug reloading Signed-off-by: Waldemar Quevedo --- server/raft.go | 3 +-- server/reload.go | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/server/raft.go b/server/raft.go index a1c17c62..6825462e 100644 --- a/server/raft.go +++ b/server/raft.go @@ -563,11 +563,10 @@ func (s *Server) lookupRaftNode(group string) RaftNode { return n } -func (s *Server) reloadDebugRaftNodes() { +func (s *Server) reloadDebugRaftNodes(debug bool) { if s == nil { return } - debug := atomic.LoadInt32(&s.logging.debug) > 0 s.rnMu.RLock() for _, ni := range s.raftNodes { n := ni.(*raft) diff --git a/server/reload.go b/server/reload.go index 7058417f..e498c6ae 100644 --- a/server/reload.go +++ b/server/reload.go @@ -1,4 +1,4 @@ -// Copyright 2017-2022 The NATS Authors +// Copyright 2017-2023 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at @@ -148,7 +148,7 @@ type debugOption struct { // However we will kick the raft nodes if they exist to reload. func (d *debugOption) Apply(server *Server) { server.Noticef("Reloaded: debug = %v", d.newValue) - server.reloadDebugRaftNodes() + server.reloadDebugRaftNodes(d.newValue) } // logtimeOption implements the option interface for the `logtime` setting.