gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

Check errors when removing test directories and files

Browse Source 
Currently in tests, we have calls to os.Remove and os.RemoveAll where we
don't check the returned error. This hides useful error messages when
tests fail to run, such as "too many open files".

This change checks for more filesystem related errors and calls t.Fatal
if there is an error.
This commit is contained in:
Jaime Piña
2021-04-06 15:49:19 -07:00
parent 3e4f6b8e4e
commit d929ee1348
38 changed files with 688 additions and 667 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
logger/log_test.go
View File

@@ -106,7 +106,7 @@ func TestStdLoggerTraceWithOutDebug(t *testing.T) {
func TestFileLogger(t *testing.T) {
tmpDir := createDir(t, "_nats-server")
defer os.RemoveAll(tmpDir)
defer removeDir(t, tmpDir)
file := createFileAtDir(t, tmpDir, "nats-server:log_")
file.Close()
@@ -178,7 +178,7 @@ func TestFileLoggerSizeLimit(t *testing.T) {
logger.Close()
tmpDir := createDir(t, "nats-server")
defer os.RemoveAll(tmpDir)
defer removeDir(t, tmpDir)
file := createFileAtDir(t, tmpDir, "log_")
file.Close()
@@ -212,9 +212,9 @@ func TestFileLoggerSizeLimit(t *testing.T) {
}
// Remove all files
os.RemoveAll(tmpDir)
removeDir(t, tmpDir)
tmpDir = createDir(t, "nats-server")
defer os.RemoveAll(tmpDir)
defer removeDir(t, tmpDir)
// Recreate logger and don't set a limit
file = createFileAtDir(t, tmpDir, "log_")
@@ -346,3 +346,10 @@ func createFileAtDir(t *testing.T, dir, prefix string) *os.File {
}
return f
}
func removeDir(t *testing.T, dir string) {
t.Helper()
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}