gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

Emit latency traces when sampling is set to headers

Browse Source 
Latency reports will include the header(s) responsible for the trace
Updated ADR to have it reflect implementation

Signed-off-by: Matthias Hanel <mh@synadia.com>
This commit is contained in:
Matthias Hanel
2020-08-11 15:34:02 -04:00
parent 9bad6725aa
commit e1350a05f3
7 changed files with 532 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
doc/adr/0003-distributed-tracing.md
View File

@@ -5,7 +5,7 @@ Author: @ripienaar
## Status
Proposed
Approved
## Context
@@ -52,15 +52,14 @@ exports: [
This enables sampling based `50%` of the service requests on this service.
I propose we support additional sampling values `zipkin`, `jaeger`, `trace_context` which will configure the server to
I propose we support the additional sampling value `headers` which will configure the server to
interpret the headers as below to determine if a request should be sampled.
## Propagating headers
The `io.nats.server.metric.v1.service_latency` advisory gets updated with additional `trace_format` and `headers` fields.
The `io.nats.server.metric.v1.service_latency` advisory gets updated with an additional `headers` field.
`headers` would just propagate all the headers unmodified. We might later add support for a whitelist here to avoid
leaking sensitive information.
`headers` contains only the headers used for the sampling decision.
```json
{
@@ -68,9 +67,8 @@ leaking sensitive information.
"id": "YBxAhpUFfs1rPGo323WcmQ",
"timestamp": "2020-05-21T08:06:29.4981587Z",
"status": 200,
"trace_format": "jaeger",
"headers": {
"Uber-Trace-Id": "09931e3444de7c99:50ed16db42b98999:0:1"
"Uber-Trace-Id": ["09931e3444de7c99:50ed16db42b98999:0:1"]
},
"requestor": {
"acc": "WEB",