Commit Graph

15 Commits

Author SHA1 Message Date
Alberto Ricart
92e00f2a40 Header ADR clarifications (#1528)
* clarifications on the ADR. Go is non-standard, and it's formatting
rules, create formatting dependencies that are not part of the spec.
Also added simplified guidance of allowed characters to help those
having to implement it.

* clarified that http.Header in go internally uses textproto.MIMEHeader.

[ci skip]
2020-09-05 19:06:55 -05:00
Matthias Hanel
e1350a05f3 Emit latency traces when sampling is set to headers
Latency reports will include the header(s) responsible for the trace
Updated ADR to have it reflect implementation

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-08-21 20:01:11 -04:00
Alberto Ricart
d2c50be093 adr describing new ldm field in the INFO protocol. 2020-07-20 10:41:06 -05:00
R.I.Pienaar
967bb66061 Merge pull request #1430 from nats-io/header-spec
Header specification from the perspective of client libraries.
2020-06-11 22:06:27 +02:00
Alberto Ricart
3c3ee22e9f changed \r to and \n to 2020-06-11 12:11:43 -05:00
R.I.Pienaar
c65134ec6d distributed tracing adr 2020-06-03 12:39:05 +02:00
Alberto Ricart
8b04a8988f removed extraneous ticks from md 2020-06-02 09:17:44 -05:00
Alberto Ricart
a10d1a45e1 review comments
removed synopsys of http header spec
2020-05-29 10:07:09 -05:00
Alberto Ricart
95a98d969e Header specification from the perspective of client libraries.
[ci skip]
2020-05-28 18:31:03 -05:00
R.I.Pienaar
3ab203d164 typed messages adr
[ci skip]

Signed-off-by: R.I.Pienaar <rip@devco.net>
2020-05-19 14:33:06 -07:00
R.I.Pienaar
7a1ec0ad27 adds API type hints to responses
Also standardise some names of response structures and create
reusable types that can be included into others to construct
our standard API requests and responses.

Fixes some json tags.

Updates the design document of the JSON responses to reflect
the implementation that was done

Signed-off-by: R.I.Pienaar <rip@devco.net>
2020-05-19 14:33:06 -07:00
R.I.Pienaar
e67c1d9d69 expand on empty requests and non json requests
[skip ci]

Signed-off-by: R.I.Pienaar <rip@devco.net>
2020-05-19 14:27:45 -07:00
R.I.Pienaar
8bf06597d4 clarify error schemas can be mostly empty 2020-05-19 14:27:45 -07:00
R.I.Pienaar
830d14bb40 move to description for error fields 2020-05-19 14:27:45 -07:00
R.I.Pienaar
ad80d2aee1 initial Architecture Decision Record 2020-05-19 14:27:45 -07:00