gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-14 18:20:42 -07:00
Code Issues Packages Projects Releases Wiki Activity
2,491 Commits 30 Branches 48 Tags
a19dcbee2ded15020ff5efa20db17a6def209b01
Commit Graph

1417 Commits

Author SHA1 Message Date
Ivan Kozlovic
a19dcbee2d Release v2.1.6 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-03-31 10:29:06 -06:00
Ivan Kozlovic
e63fc5f195 Merge pull request #1318 from nats-io/monitoring 
[ADDED] Option to include subscription details in monitoring responses
 2020-03-30 15:51:51 -06:00
Matthias Hanel
8a75418386 Using AccountResolver url from operator jwt. 
If resolver is specified separately, it takes precedence.
nsc push automatically adds /accounts. That's why its added here too.
Operator jwt reload is not supported and is not taken into account.
On startup the AccountResolver url is checked and exits if it can't be
reached.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-30 15:43:32 -04:00
Matthias Hanel
30ba333663 Adding an option to include subscription details in monitoring responses. 
Applies to routez and connz and closed connections.
Enable by specifying subs=detail

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-23 12:25:51 -04:00
Ivan Kozlovic
b46a011c87 Merge pull request #1316 from nats-io/fix_1313 
Add TLS 1.3 (and new ciphers) in the tlsVersion output
 2020-03-19 17:30:51 -06:00
Ivan Kozlovic
6d92410a1f Merge pull request #1308 from nats-io/loop 
[FIXED] loop detection by checking for duplicate lds subscriptions
 2020-03-19 17:29:48 -06:00
Ivan Kozlovic
d1276ad038 Add TLS 1.3 (and new ciphers) in the tlsVersion output 
Also changed unknown version to "0x.." to show that value is hexa.

Resolves #1313

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-03-18 10:09:23 -06:00
Matthias Hanel
6f77a54118 [FIXED] loop detection by checking for duplicate lds subscriptions 
This is in addition to checking if the own subscription comes back.
The duplicated lds subscription must come from a different client.
Added unit tests.
Also prefixed lds with '$' to mark it as system subject going forward.

This moves the loop detection check past other checks.
These checks should not trigger in cases where a loop is initially detected.

Fixes #1305

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-17 19:06:35 -04:00
Matthias Hanel
4aede98bcc Turn if into assignment and minimize changes by capturing s.gacc. 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-17 14:56:34 -04:00
Matthias Hanel
b0ded55b43 Make sure server lock is held while accessing server.gacc 
Fixes #1314 by:
There was a data race with a write during reloadAuthorization.
Locking was added to all places where it was missing.
In situations were it appeared feasible, access was moved into existing
lock/unlock.
Where it was added, the lock order was already established.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-17 14:23:23 -04:00
Matthias Hanel
a57bfc4d56 Remove double trace on split buffer 
The trace in question was not there prior to tracing change.
Fixes #1310, by removing it.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-13 21:06:30 -04:00
Ivan Kozlovic
5eebf02e5f Fixed TestVersionMatchesTag test 
When no tag was set, os.Getenv("TRAVIS_TAG") would return empty string.
Travis now set TRAVIS_TAG to `''`. So check for both.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-03-09 10:13:32 -06:00
Ivan Kozlovic
cbc0e5848a Merge pull request #1300 from nats-io/reload 
[FIXED] trace/debug/sys_log reload will affect existing clients
 2020-03-09 09:48:24 -06:00
Ivan Kozlovic
b7a5ad3c5b Merge pull request #1304 from nats-io/varz 
[ADDED] Value of GOMAXPROCS in /varz monitoring output
 2020-03-09 09:47:50 -06:00
Matthias Hanel
2135d78634 moving maxProcs and numCores into createVarz. They do not change. 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-06 19:40:51 -05:00
Matthias Hanel
8a74add60b Include port in trace 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-06 15:44:32 -05:00
Matthias Hanel
0e2de4c9da Include value of GOMAXPROCS in /varz monitoring output 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-06 14:00:04 -05:00
Matthias Hanel
59a2102f74 Fixed RUnlock 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-06 12:17:13 -05:00
Matthias Hanel
d28ae249ed Moving client update outside of the server/gateway lock 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-06 12:00:47 -05:00
Matthias Hanel
6a1c3fc29b Moving inbound tracing to the caller (client.parse) 
Tracing for outgoing operations is always done while
holding the client lock.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-04 17:31:18 -05:00
Matthias Hanel
fe373ac597 Incorporating comments. 
c -> client
defer in oneliner
argument order

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-04 15:48:19 -05:00
Matthias Hanel
f5bd07b36c [FIXED] trace/debug/sys_log reload will affect existing clients 
Fixed #1296, by altering client state on reload

Detect a trace level change on reload and update all clients.
To avoid data races, read client.trace while holding the lock,
pass the value into functionis that trace while not holding the lock.
Delete unused client.debug.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-04 13:54:15 -05:00
Ivan Kozlovic
6f3418687b Capture original length of the first slice and updated test 
Changed test to make the previous code in flushOutbound fail.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-03-03 19:12:42 -07:00
Ivan Kozlovic
fd8539f15f [FIXED] Incorrect buffer reuse in case of partial connection write 
Added a test that demonstrates the issue and a proposed fix.

Also decrement c.out.pb if closing due to max pending limit.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-03-03 16:50:03 -07:00
Ivan Kozlovic
6465afd062 Merge pull request #1291 from nats-io/warning-debug 
[FIXED] configuration warnings do not cause cmd line options to be skipped
 2020-03-03 09:11:18 -07:00
Matthias Hanel
ed1255936c [FIXED] configuration warnings do not cause cmd line options to be skipped 
Fixes #1290, where -DV option was skipped when config file had a warning

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-02 20:40:13 -05:00
Matthias Hanel
a8e6af30a3 On client connect, send first ping after ping interval. 
On connect message resend reset timer with setFirstPingTimer, so RTT can
be obtained quicker.

Disable short first ping in default server options for client_test.
In log_test prevent immediate scheduling by setting ping interval.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-02 20:10:15 -05:00
Ivan Kozlovic
34e4c64e50 Merge pull request #1295 from nats-io/sys-trace 
Adding option to enable tracing the system account. (default: false)
 2020-03-02 16:48:55 -07:00
Ivan Kozlovic
fcb6dfe9a7 Merge pull request #1286 from nats-io/error-suggestion 
Suggestion to improve tracing in nats-server through wrapping errors
 2020-03-02 16:44:24 -07:00
Matthias Hanel
9539199b88 Fixed help text and variable naming 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-02 15:09:52 -05:00
Matthias Hanel
6bd6757ca5 Renamed traceSystemAcc to traceSysAcc 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-02 14:32:42 -05:00
Matthias Hanel
5fa9b654ce changing sys_trace to trace_verbose, adding -VV and -DVV flags 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-02 14:27:58 -05:00
Matthias Hanel
bf952a3807 Adding option to enable tracing the system account. (default: false) 
Use sys_trace option in config file or --sys_trace on the command line

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-03-01 19:42:40 -05:00
Derek Collison
087854c9d8 Rename to ClientIP for INFO 
Signed-off-by: Derek Collison <derek@nats.io>
 2020-02-29 13:23:22 -08:00
Derek Collison
d521e1594d Place server's version of client IP in INFO 
Signed-off-by: Derek Collison <derek@nats.io>
 2020-02-28 18:27:08 -08:00
Ivan Kozlovic
7ab9c76f2b Fixed benchmark tests to be able to run with Go 1.13+ 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-02-26 12:12:18 -07:00
Matthias Hanel
2754968e33 Renaming IsErr to ErrorIs 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-25 19:53:09 -05:00
Matthias Hanel
b6d5906154 Only use errors.Is backwards compatibility code, delete gobackcomp pkg 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-25 19:26:17 -05:00
Matthias Hanel
b57ea29002 Add missing delete from rename 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-25 18:35:11 -05:00
Matthias Hanel
5b8e7c1a41 Deleting dead code 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-25 18:16:50 -05:00
Matthias Hanel
d8297ddf41 Adding a go version compatibility package. 
Currently enables Errors.Is functionality as ErrorsIs.
Using this functionality in errors.go and unit tests.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-25 18:08:04 -05:00
Matthias Hanel
c18a5a2582 Fixing typos, copyright date and changed type in log.go/Error func 
added comment and changed type Error(c,sc)

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-24 19:37:25 -05:00
Matthias Hanel
d1d34d2638 Suggestion to improve tracing in nats-server through wrapping errors 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-24 16:00:46 -05:00
Ivan Kozlovic
62bacf1044 Merge pull request #1283 from nats-io/fix_flappers 
Fixed flappers
 2020-02-19 19:32:29 -07:00
Ivan Kozlovic
37291df206 Fixed yet another flapper 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-02-19 17:33:16 -07:00
Ivan Kozlovic
156bf7b381 Updates based on code review 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-02-19 16:52:41 -07:00
Ivan Kozlovic
8e4b449119 Fixed flappers 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2020-02-19 13:19:08 -07:00
Matthias Hanel
329cc7225b Use constant for error 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-18 10:54:12 -05:00
Matthias Hanel
82a275943e Fix unreliable test 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-17 20:22:52 -05:00
Matthias Hanel
db83b8a55a Avoid all else and adhere to general style. Adding Flush as requested. 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2020-02-17 16:52:13 -05:00