Matthias Hanel
59a2102f74
Fixed RUnlock
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-06 12:17:13 -05:00
Matthias Hanel
d28ae249ed
Moving client update outside of the server/gateway lock
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-06 12:00:47 -05:00
Matthias Hanel
6a1c3fc29b
Moving inbound tracing to the caller (client.parse)
...
Tracing for outgoing operations is always done while
holding the client lock.
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-04 17:31:18 -05:00
Matthias Hanel
fe373ac597
Incorporating comments.
...
c -> client
defer in oneliner
argument order
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-04 15:48:19 -05:00
Ivan Kozlovic
8a5b9269d7
Merge pull request #1301 from nats-io/ulimit-unittest
...
Modifying unit test error message to hint at ulimit -n possibly being too low
2020-03-04 12:52:15 -07:00
Matthias Hanel
68efc95a60
Modifying unit test error message to hint at ulimit -n possibly being too low
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-04 14:30:35 -05:00
Matthias Hanel
f5bd07b36c
[FIXED] trace/debug/sys_log reload will affect existing clients
...
Fixed #1296 , by altering client state on reload
Detect a trace level change on reload and update all clients.
To avoid data races, read client.trace while holding the lock,
pass the value into functionis that trace while not holding the lock.
Delete unused client.debug.
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-04 13:54:15 -05:00
Ivan Kozlovic
51596b7be3
Merge pull request #1298 from nats-io/fix_nobuf_reuse_on_partial
...
[FIXED] Incorrect buffer reuse in case of partial connection write
2020-03-04 08:33:24 -07:00
Ivan Kozlovic
6f3418687b
Capture original length of the first slice and updated test
...
Changed test to make the previous code in flushOutbound fail.
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-03-03 19:12:42 -07:00
Ivan Kozlovic
fd8539f15f
[FIXED] Incorrect buffer reuse in case of partial connection write
...
Added a test that demonstrates the issue and a proposed fix.
Also decrement c.out.pb if closing due to max pending limit.
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-03-03 16:50:03 -07:00
Ivan Kozlovic
6465afd062
Merge pull request #1291 from nats-io/warning-debug
...
[FIXED] configuration warnings do not cause cmd line options to be skipped
2020-03-03 09:11:18 -07:00
Matthias Hanel
ed1255936c
[FIXED] configuration warnings do not cause cmd line options to be skipped
...
Fixes #1290 , where -DV option was skipped when config file had a warning
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-02 20:40:13 -05:00
Ivan Kozlovic
08d1da459b
Merge pull request #1289 from nats-io/telnet
...
Do not send ping to presumed telnet clients until they connected/send ping
2020-03-02 18:30:45 -07:00
Matthias Hanel
a8e6af30a3
On client connect, send first ping after ping interval.
...
On connect message resend reset timer with setFirstPingTimer, so RTT can
be obtained quicker.
Disable short first ping in default server options for client_test.
In log_test prevent immediate scheduling by setting ping interval.
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-02 20:10:15 -05:00
Ivan Kozlovic
34e4c64e50
Merge pull request #1295 from nats-io/sys-trace
...
Adding option to enable tracing the system account. (default: false)
2020-03-02 16:48:55 -07:00
Ivan Kozlovic
fcb6dfe9a7
Merge pull request #1286 from nats-io/error-suggestion
...
Suggestion to improve tracing in nats-server through wrapping errors
2020-03-02 16:44:24 -07:00
Matthias Hanel
9539199b88
Fixed help text and variable naming
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-02 15:09:52 -05:00
Matthias Hanel
6bd6757ca5
Renamed traceSystemAcc to traceSysAcc
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-02 14:32:42 -05:00
Matthias Hanel
5fa9b654ce
changing sys_trace to trace_verbose, adding -VV and -DVV flags
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-02 14:27:58 -05:00
Matthias Hanel
bf952a3807
Adding option to enable tracing the system account. (default: false)
...
Use sys_trace option in config file or --sys_trace on the command line
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-03-01 19:42:40 -05:00
Derek Collison
f8a53a1408
Merge pull request #1293 from nats-io/client_ip
...
Place server's version of client IP in INFO
2020-02-29 13:32:05 -08:00
Derek Collison
087854c9d8
Rename to ClientIP for INFO
...
Signed-off-by: Derek Collison <derek@nats.io >
2020-02-29 13:23:22 -08:00
Derek Collison
d521e1594d
Place server's version of client IP in INFO
...
Signed-off-by: Derek Collison <derek@nats.io >
2020-02-28 18:27:08 -08:00
Ivan Kozlovic
bb432f47e9
Merge pull request #1287 from nats-io/fix_bench_tests
...
Fixed benchmark tests to be able to run with Go 1.13+
2020-02-26 15:18:09 -07:00
Ivan Kozlovic
7ab9c76f2b
Fixed benchmark tests to be able to run with Go 1.13+
...
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-26 12:12:18 -07:00
Matthias Hanel
2754968e33
Renaming IsErr to ErrorIs
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-25 19:53:09 -05:00
Matthias Hanel
b6d5906154
Only use errors.Is backwards compatibility code, delete gobackcomp pkg
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-25 19:26:17 -05:00
Matthias Hanel
b57ea29002
Add missing delete from rename
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-25 18:35:11 -05:00
Matthias Hanel
5b8e7c1a41
Deleting dead code
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-25 18:16:50 -05:00
Matthias Hanel
d8297ddf41
Adding a go version compatibility package.
...
Currently enables Errors.Is functionality as ErrorsIs.
Using this functionality in errors.go and unit tests.
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-25 18:08:04 -05:00
Matthias Hanel
c18a5a2582
Fixing typos, copyright date and changed type in log.go/Error func
...
added comment and changed type Error(c,sc)
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-24 19:37:25 -05:00
Matthias Hanel
d1d34d2638
Suggestion to improve tracing in nats-server through wrapping errors
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-24 16:00:46 -05:00
Ivan Kozlovic
62bacf1044
Merge pull request #1283 from nats-io/fix_flappers
...
Fixed flappers
2020-02-19 19:32:29 -07:00
Ivan Kozlovic
37291df206
Fixed yet another flapper
...
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-19 17:33:16 -07:00
Ivan Kozlovic
156bf7b381
Updates based on code review
...
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-19 16:52:41 -07:00
Ivan Kozlovic
8e4b449119
Fixed flappers
...
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-19 13:19:08 -07:00
Ivan Kozlovic
dbb083210a
Merge pull request #1282 from nats-io/ctrl-line-error
...
Use constant for error
2020-02-18 09:07:05 -07:00
Matthias Hanel
329cc7225b
Use constant for error
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-18 10:54:12 -05:00
Ivan Kozlovic
a5b3cf2ead
Merge pull request #1281 from nats-io/config
...
parse ping_interval as duration, else assume seconds and warn
2020-02-17 18:29:17 -07:00
Matthias Hanel
82a275943e
Fix unreliable test
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-17 20:22:52 -05:00
Matthias Hanel
db83b8a55a
Avoid all else and adhere to general style. Adding Flush as requested.
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-17 16:52:13 -05:00
Matthias Hanel
f7a84e3662
Removed unnecessary else
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-17 14:03:30 -05:00
Matthias Hanel
3fbf8cac2e
parse ping_interval as duration, else assume seconds and warn
...
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-17 12:59:34 -05:00
Ivan Kozlovic
c22b2c097d
Merge pull request #1276 from nats-io/fix_lame_duck_mode_shutdown
...
[FIXED] Server that is sent the lame duck mode signal does not exit
2020-02-10 18:13:49 -07:00
Ivan Kozlovic
59f99c1233
Merge pull request #1274 from nats-io/config
...
[IMPROVED] Replace panic with error during configuration parsing/reload
2020-02-10 18:05:44 -07:00
Ivan Kozlovic
a6874b2107
[FIXED] Server that is sent the lame duck mode signal does not exit
...
Resolves #1275
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-10 17:35:40 -07:00
Matthias Hanel
c7e4d261f4
recover from error during parsing or reload will cause a crash
...
Keep track of the last token used.
When recovering from a panic, create a configErr use that token.
Signed-off-by: Matthias Hanel <mh@synadia.com >
2020-02-10 18:51:12 -05:00
Matthias Hanel
82ebe084c9
recover from error during parsing or reload will cause a crash
...
This will also result in a line number where the issue is
2020-02-07 18:18:22 -05:00
Ivan Kozlovic
c0b97b7a22
Merge pull request #1272 from nats-io/add_resolver_tls
...
[ADDED] Ability to specify TLS configuration for account resolver
2020-02-03 17:17:14 -07:00
Ivan Kozlovic
7208e7f817
[ADDED] Ability to specify TLS configuration for account resolver
...
A new config section allows to specify specific TLS parameters for
the account resolver:
```
resolver_tls {
cert_file: ...
key_file: ...
ca_file: ...
}
```
Resolves #1271
Signed-off-by: Ivan Kozlovic <ivan@synadia.com >
2020-02-03 14:35:05 -07:00