gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity
8,304 Commits 30 Branches 48 Tags
c583f7fdc7fc8baf70c3cf66fdf31987c4012dcc
Commit Graph

5648 Commits

Author SHA1 Message Date
Derek Collison
c583f7fdc7 Bump to 2.10.2-RC.7 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 21:05:56 -07:00
Derek Collison
ee4d6ee40e [FIXED] Account resolver lock inversion (#4588) 
There was a lock inversion but low risk since it happened during server
initialization. Still fixed it and added the ordering in
locksordering.txt file.

Also fixed multiple lock inversions that were caused by tests.

Signed-off-by: Ivan Kozlovic <ijkozlovic@gmail.com>
 2023-09-25 21:05:11 -07:00
Ivan Kozlovic
ca2a961fa7 [FIXED] JetStream: stream assignment data race 
Two go routines could possibly execute the stream assignment at
the same time. A WaitGroup was used to prevent that, but an issue
caused the data race and possible concurrent execution.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2023-09-25 16:11:09 -06:00
Ivan Kozlovic
a84ce61a93 [FIXED] Account resolver lock inversion 
There was a lock inversion but low risk since it happened during
server initialization. Still fixed it and added the ordering
in locksordering.txt file.

Also fixed multiple lock inversions that were caused by tests.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2023-09-25 15:09:11 -06:00
Derek Collison
83cc80ab74 Bump to 2.10.2-RC.6 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 13:33:03 -07:00
Derek Collison
73f8f87b86 [IMPROVED] The func subjectIsSubsetMatch() is heavy so do without the account lock. (#4586) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 13:32:38 -07:00
Derek Collison
fb4e97e2ec If we know bigger go ahead an allocate. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 13:12:13 -07:00
Neil Twigg
11feadfe7b Add prof_block_rate option for enabling/configuring the block profile 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-25 21:04:25 +01:00
Derek Collison
382da48180 The func subjectIsSubsetMatch() is heavy so do without the account lock. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 13:01:46 -07:00
Derek Collison
54d4640e8b Bump to 2.10.2-RC.5 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 12:32:51 -07:00
Derek Collison
a0029181ae Fix datarace 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 12:04:42 -07:00
Derek Collison
b70f874640 Moved to atomics to detect if we have mapped subjects for an account since check for each inbound message. 
If an account has many connections on a server under heavy load this could be contended.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 11:43:34 -07:00
Derek Collison
7ce47fd182 Move server running state to atomic to avoid contention at NRG layer. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 11:18:15 -07:00
Derek Collison
e594da52e4 Bump to 2.10.2-RC.4 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 09:21:12 -07:00
Derek Collison
3ecb741d4d [IMPROVED] Make sure to issue warning on reset for bad state (#4583) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 09:19:18 -07:00
Derek Collison
e46f49f5d5 Make sure to issue warning on reset for bad state 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-25 09:04:54 -07:00
Neil Twigg
d4e8a44499 Set S2 writer concurrency to 1 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-25 09:54:54 +01:00
Derek Collison
f3411f623d Bump to 2.10.2-RC.3 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-24 16:03:49 -07:00
Derek Collison
121adb4719 Bump start interval for cleanup check 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-24 15:44:15 -07:00
Derek Collison
f95ef63ae1 In lameduck mode shutdown jetstream at start, do not leave running during connection drain. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-24 14:42:59 -07:00
Derek Collison
13dcf319b4 Make sure to not forward a message across a route for dq sub when we are a spoke leaf node. 
Mimi same behavior for normal subs.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-24 13:15:39 -07:00
Waldemar Quevedo
637d8f2921 Skip enabling direct gets if no commits (#4576) 2023-09-22 17:25:35 -07:00
Waldemar Quevedo
89d33d960b Skip enabling direct gets if no commits 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
 2023-09-22 17:08:46 -07:00
Derek Collison
bbe172df8d Bump to 2.10.2-RC.2 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-22 14:34:13 -07:00
Derek Collison
2716248b5e Protect against going upside down on mb.msgs. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-22 14:17:45 -07:00
Derek Collison
ece431fc74 Bump to 2.10.2-RC.1 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-22 10:26:50 -07:00
Derek Collison
4824085171 Hold lock here as well 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-22 10:25:58 -07:00
Derek Collison
65e0fbfa51 Make install snapshot errors rate limited for when catching up 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-22 10:23:02 -07:00
Waldemar Quevedo
4cb7acb85e Bump v2.10.2 (#4569) 2023-09-21 19:01:05 -07:00
Derek Collison
21e81a2961 We will panic since we unlock the mb in removeMsgBlock 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-21 18:34:38 -07:00
Byron Ruth
b36644b229 Bump v2.10.2 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-09-20 21:06:42 -04:00
Byron Ruth
4a1d399a21 Release v2.10.1 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-09-20 12:54:02 -04:00
Tomasz Pietrek
ac2669a022 Fix consumer limits 
Test didn't catch this error, as by default, old JS client
sets ack policy to none. If policy is different, it will fail
to create consumer with defaults.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
 2023-09-20 17:37:05 +02:00
Jean-Noël Moyne
9fc2603263 Removes the single subject transform dest field from StreamSource 
Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Co-authored-by: Neil Twigg <neil@nats.io>

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-20 15:28:45 +01:00
Jean-Noël Moyne
40ce0a9d7e Use filter_subject when calling extended consumer create API 
The server consumer creation code is picky and does indeed not accept a request send to the ExT subject if that request specifies the subject filter in the array (even if there is only one entry in the array).

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Neil Twigg <neil@nats.io>

Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Co-authored-by: Neil Twigg <neil@nats.io>
 2023-09-20 10:51:19 +01:00
Neil Twigg
ad63d702c4 Use new consumer create subject when single subject filter specified in SubjectFilters 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-20 10:51:19 +01:00
Ivan Kozlovic
579ee3b828 [FIXED] LeafNode: TLS Handshake when remote does not have a tls{} block 
If a leafnode remote configuration does not have a tls{} block but
connect to a hub that requires TLS, the handshake between the two
servers will fail. A simple workaround is to add in the remote
configuration an empty tls{} block.

This issue was introduced in v2.10.0 due to some refactoring in
order to support compression.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2023-09-19 19:50:50 -06:00
Byron Ruth
6ba8272034 Bump 2.10.1 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-09-19 16:04:35 -04:00
Byron Ruth
f677536a88 Relase v2.10.0 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-09-19 15:26:16 -04:00
Neil Twigg
01872d2aa8 Fix empty string constants 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-19 19:07:17 +01:00
Neil Twigg
8b60131e92 Fix race condition in clientHasMovedToDifferentAccount 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-19 18:52:34 +01:00
Neil
ecbfac862c Ignore subject_transform_dest in stream sourcing (#4558) 
This is a safer (less lines of code touched) alternative to #4557 for
now, which simply ignores the `subject_transform_dest` field in the API
and the stream assignments. We'll still look to merge the other PR to
clean up but will do so post-release when we have more time to test it.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-19 18:10:01 +01:00
Neil Twigg
887b92bfe2 Fix data race in setStreamAssignment by ensuring JS lock held 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-19 17:42:25 +01:00
Neil Twigg
dff12e465e Ignore subject_transform_dest in stream sourcing 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-19 11:35:26 +01:00
Derek Collison
3dc0627811 Bump to 2.10.0-RC.6 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-18 13:53:25 -07:00
Waldemar Quevedo
2d23e9b348 Fix to stop forwarding proposals in consumers after scaling down a stream (#4556) 
Sometimes when scaling down a stream, a raft node could continue
forwarding proposals after already being closed, in the debug logs this
can be confirmed by many entries logging 'Direct proposal ignored, not
leader (state: CLOSED)'.
 2023-09-18 13:51:44 -07:00
Derek Collison
71b8a33456 Update to not pop directly, just bail when we detect leadership change 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-18 13:27:27 -07:00
Waldemar Quevedo
ea775a80e8 Skip TestJetStreamClusterRestartThenScaleStreamReplicas for now 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
 2023-09-18 12:46:53 -07:00
Derek Collison
850c89e175 When scaling a consumer down make sure to pop the loopAndForwardProposals go routine 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-18 12:26:25 -07:00
Waldemar Quevedo
27245891f2 Add test for scaling replica with pull consumers 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
 2023-09-18 12:26:05 -07:00