Commit Graph

6893 Commits

Author SHA1 Message Date
Derek Collison
b3f0dbdde4 Merge pull request #3884 from nats-io/fix-consumer-cleanup
[FIXED] Named push consumers with inactive thresholds deleted when still active.
2023-02-19 08:51:37 -07:00
Derek Collison
06fd81d096 Fixed a bug where a named consumer under interest policy was spinning up inactive threshold timers in all replicas not just the leader.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-19 06:08:43 -08:00
Derek Collison
9de8c08537 Merge pull request #3882 from nats-io/replica-warn
[FIXED] Do not warn if consumer replicas configured to 0
2023-02-18 13:02:03 -07:00
Derek Collison
e270e9538f Do not warn if consumer replicas condigured to 0
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-18 11:50:26 -08:00
Derek Collison
35526b0433 Merge pull request #3881 from nats-io/bad-consumer-delete
[FIXED] Do not delete consumers on restarts with non-fatal update errors.
2023-02-18 12:31:02 -07:00
Derek Collison
6a62ac4560 Fix for merge conflict
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-18 11:12:15 -08:00
Derek Collison
6a4c61e1a3 Merge branch 'main' into bad-consumer-delete 2023-02-18 11:09:56 -08:00
Derek Collison
7f5bef4b0f Merge pull request #3880 from nats-io/p-consumer-create
[IMPROVED] Parallel consumer
2023-02-18 10:47:12 -07:00
Derek Collison
01fa89a0b4 Fix for deleting consumers on restarts and non-fatal update errors.
If there was a spurious error on restart, or possibly on an update, we could delete a consumer which was the incorrect behavior.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-18 09:46:52 -08:00
Derek Collison
efa3bcc49d Parallel consumer creation could drop responses (create and info) and could also run monitorConsumer twice.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-18 05:16:05 -08:00
Derek Collison
689d521c82 Merge pull request #3878 from nats-io/test-fix
Fix to flapping test to make sure we do not quickly blow away all consumer state.
2023-02-17 15:53:36 -07:00
Derek Collison
2d794d09e1 Fix to flapping test to make sure we do not quickly blow away all consumer state.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-17 14:23:34 -08:00
Derek Collison
52e5995a08 Merge pull request #3877 from nats-io/consumer-info-optimization
[IMPROVED] ConsumerInfo request processing.
2023-02-17 11:30:47 -07:00
Derek Collison
11b0f214d0 Do not re-calculate NumPending on consumer info calls.
We noticed this was being called alot in user environments.
When the consumer was filtered with a wilcard and the stream had a high cardinality of subjects and was falling behind this could take a substantial amount of time.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-16 16:30:14 -08:00
Derek Collison
b91143ad14 Merge pull request #3876 from nats-io/purge-accounting
[FIXED] Extended Purge accounting was not updating account usage.
2023-02-16 17:25:22 -07:00
Derek Collison
0cb01f9e7a Make sure we update storage accounting on extended version purge for filestore.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-16 13:18:40 +04:00
Derek Collison
b3b9e888f3 Merge pull request #3873 from nats-io/diskio-test
[FIXED] Adjusted test to correspond to new limit of 1024.
2023-02-15 20:45:15 -07:00
Derek Collison
98e6b2059d Merge pull request #3872 from nats-io/js-parallel-test-race
Fix TestJetStreamParallelConsumerCreation race
2023-02-15 20:26:20 -07:00
Derek Collison
32b5ec16dd Fixed test to correspond to new limit of 1024.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-16 07:16:19 +04:00
Waldemar Quevedo
4452f64d73 Fix TestJetStreamParallelConsumerCreation race
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-02-15 17:23:48 -08:00
Derek Collison
345496f331 Merge pull request #3867 from nats-io/improvements
Improvements to Filestore
2023-02-14 05:35:40 -07:00
Derek Collison
3bc0af70d0 Only update per subject information if we know we have an update.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-13 20:12:35 +02:00
Derek Collison
e2f9fb73a9 Increase limit for internal blocking IO vs num cores.
Will help in slow IO situations and lots of expire cache calls.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-13 18:44:25 +02:00
Derek Collison
1e3c2810f4 Improve expireMsgs minAge calculation for when lots of messages to expire in each callback.
This happens when under extreme load as shown in the skipped test.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-13 18:39:39 +02:00
Neil
f3fa39c321 Merge pull request #3862 from nats-io/neil/accountstackoverflow
Fix stack overflow panic in reverse entry check when inbox ends with wildcard
2023-02-13 10:54:50 +00:00
Neil Twigg
ba0b1f8bd3 Fix stack overflow panic in reverse entry check when inbox ends with wildcard 2023-02-13 09:45:50 +00:00
Derek Collison
7afddb3aac Merge pull request #3860 from nats-io/compact-subjects-fix
Make sure we adjust per subject info when doing a Compact().
2023-02-10 08:16:57 -07:00
Derek Collison
0da2a150cc Make sure we adjust per subject info when doing a Compact().
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-10 07:21:02 +02:00
Derek Collison
72bce6cf8e Merge pull request #3859 from nats-io/fix-service
Small fix to nats-server-hardened.service
2023-02-09 21:34:20 -07:00
Waldemar Quevedo
e6dc18582e Small fix to nats-server-hardened.service 2023-02-09 18:53:40 -08:00
Neil
9f5e1509b9 Merge pull request #3852 from nats-io/neil/fstests
File store subtests
2023-02-08 16:49:20 +00:00
Neil Twigg
9e8a5bfa3b File store subtests 2023-02-08 09:55:49 +00:00
Waldemar Quevedo
bdf7fc540c Merge pull request #3849 from nats-io/bump-2-9-15
Bump v2.9.15-beta
2023-02-06 14:20:37 -06:00
Byron Ruth
dd96f9b572 Bump v2.9.15-beta
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-06 14:43:42 -05:00
Waldemar Quevedo
74ae59a48c Merge pull request #3847 from nats-io/release-2-9-14
Release v2.9.14
2023-02-06 13:41:21 -06:00
Byron Ruth
8db9ca6d7b Release v2.9.14
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-06 14:17:25 -05:00
Derek Collison
525410127b Merge pull request #3846 from nats-io/consumer-snapshot-logic
Revert consumer snapshot logic
2023-02-06 11:19:29 -07:00
Derek Collison
6a2063f5b3 Revert logic
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-06 22:14:37 +04:00
Derek Collison
c1a6f3ecad Merge pull request #3845 from nats-io/update-filter
[FIXED] Updating consumer filter subject possible panic and deadlock.
2023-02-06 10:55:59 -07:00
Derek Collison
b611e37e95 For updating a consumer filter subject make sure locking ordere correct and that our sublist is present.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-06 21:34:48 +04:00
Derek Collison
0ffce191cd Bump to 2.9.14-beta
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 22:26:19 -08:00
Derek Collison
f4a80838d2 Merge pull request #3844 from nats-io/snapshots-fix
[FIXED] Snapshots Issue
2023-02-04 23:20:08 -07:00
Derek Collison
b22ed47a26 Use fast state in case many interior deletes and small fix for staticcheck
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 13:55:41 -08:00
Derek Collison
9c02be2409 Various fixes for snapshots.
Due to bug, in rare circumstances could write an empty snapshot for aplied == 0. This would cause a spinning at the raft layer.

1. Allow Truncate() to also properly do a reset of the store when terms were only mismatch.
2. During testing fixed memstore truncate and also made sure per subject info was also cleaned up.
3. Then added fix to detect a bad snapshot on initialization and remove.
4. Do not allow snapshots for applied == 0.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 13:46:06 -08:00
Waldemar Quevedo
6d94b4181f Merge pull request #3840 from nats-io/bump-2.9.13-beta
Bump 2.9.13-beta
2023-02-02 13:06:19 -06:00
Byron Ruth
a56dcc60c2 Bump 2.9.13-beta
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-02 14:01:49 -05:00
Waldemar Quevedo
194d9cee38 Merge pull request #3839 from nats-io/release-2-9-12
Release v2.9.12
2023-02-02 12:55:38 -06:00
Byron Ruth
035edeaecb Release v2.9.12
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-02 13:26:59 -05:00
Derek Collison
5d9a3a10bd Merge pull request #3838 from nats-io/jarema/fix-consumers-after-purge
Fix current consumers not getting messages after purge
2023-02-02 07:48:00 -08:00
Tomasz Pietrek
46af979871 Fix current consumers not getting messages after purge
Until now, purge updated all consumers sequences
even if purge subject was only a subset of given consumer filter.
Because of that, even messages from not purged subjects were not fetched
or properly accounted for existing consumers.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-02 16:27:32 +01:00