gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-14 10:10:42 -07:00
Code Issues Packages Projects Releases Wiki Activity
4,843 Commits 30 Branches 48 Tags
fc9af36df69617e3210cd57dd347dc3eb4308708
Commit Graph

3145 Commits

Author SHA1 Message Date
Matthias Hanel
2ec87a56ba fixed unit tests where SequencePair comparisons fail due to time last_active 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2021-08-16 21:05:12 -04:00
Derek Collison
3f099f6719 Add in warn for error on catchup 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-16 08:03:53 -07:00
Ivan Kozlovic
23e30b0b98 Merge pull request #2442 from nats-io/fix_ln_wss 
[FIXED] LeafNode with "wss://.." url was not always initiating TLS
 2021-08-16 08:37:20 -06:00
Ivan Kozlovic
d7a124baaf [FIXED] LeafNode with "wss://.." url was not always initiating TLS 
If the remote did not have any TLS configuration, the URL scheme
"wss://" was not used as the indicating that the connection should
be attempted as a TLS connection, causing "invalid websocket connection"
in the server attempting to create the remote leafnode connection.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2021-08-15 12:39:10 -06:00
Derek Collison
969c563822 Fix for flapper 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-15 11:31:55 -07:00
Derek Collison
75ae7c6032 When an account asked for connz should be client and leaf connections only by default. 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-15 11:04:23 -07:00
Derek Collison
f07a86c6db Merge branch 'main' into acc-connz 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 18:13:43 -07:00
Derek Collison
944dd248c4 Fix for tests 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 17:39:51 -07:00
Derek Collison
cdb5a56329 Fix for flapping test 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 15:26:27 -07:00
Derek Collison
b095870c2a Fixed a leak of internal clients for JetStream consumers. 
We were not properly unregistering from the account on cleanup.

Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 15:09:42 -07:00
Derek Collison
b6c0412d2a More fixes for some flapping tests 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 13:35:04 -07:00
Derek Collison
14572b080b Fixed and moved large purge test to no race 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 13:07:46 -07:00
Derek Collison
9d7123213a Keep SequencePair vs SequenceInfo 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 12:01:29 -07:00
Derek Collison
c90dc48ba9 Fix for flapper 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 11:44:17 -07:00
Derek Collison
9405b77e46 Added in last active reporting for consumers for delivered and ack floor. 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 11:36:27 -07:00
Derek Collison
969cf60def Add in push bound status for consumer info. 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-14 08:35:40 -07:00
Derek Collison
c4a78d91b7 Remove PushActive 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-13 15:11:31 -07:00
Derek Collison
5ec5020a8b Add in DeliverGroup to consumer as optional queue group. 
Changed sublist register for notifications to be queue bound.

Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-13 15:07:56 -07:00
Derek Collison
9f50b66ad7 Break once we see interest 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-13 10:41:26 -07:00
Derek Collison
10167b1bcf Added in ability for normal accounts to access scoped connz info. 
Added in client kind and sub type for clients.
Added in ability to filter connections based on matching subject interest.

Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-13 10:19:12 -07:00
Matthias Hanel
1d9a891477 Merge pull request #2430 from nats-io/issuer-2415 
[fixed] issue where js overwrote leafnode remotes permissions from creds
 2021-08-12 15:12:37 -04:00
Derek Collison
d252f0f700 Make sure PushActive is nil for pull consumers 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-12 10:15:55 -07:00
Matthias Hanel
d39822e1d0 added check assuring subscription made it to other end of leaf connection 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2021-08-12 12:57:50 -04:00
Matthias Hanel
db9fd45be2 [fixed] issue where js overwrote leafnode remotes permissions from creds 
Fixes #2415. We did a set instead of merge.
changes in `jwt_test.go` are to make the `createUserWithLimit` usable by my new test.

Signed-off-by: Matthias Hanel <mh@synadia.com>
 2021-08-12 12:57:50 -04:00
Matthias Hanel
d6de19c649 Made test more predictable by waiting for leader after leader shutdown 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2021-08-12 12:34:15 -04:00
Derek Collison
98f7d63b84 Fix for data race and corruption 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-12 06:14:19 -07:00
Derek Collison
c9875e09a0 Fix for a flapper 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-12 06:13:47 -07:00
Derek Collison
54443312a4 Fix for flapper 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-11 16:53:58 -07:00
Derek Collison
c781256dda Add in deliver status for consumer info 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-11 15:41:33 -07:00
Derek Collison
da3c89efda Add domain to PubAck1 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-11 13:25:24 -07:00
Matthias Hanel
9c21fe92e1 Merge pull request #2431 from nats-io/fc-export 
fixed unit test to require fc export as well
 2021-08-11 13:41:29 -04:00
scottf
84d37e8a92 assign default to MaxAckPending when AckExplicit -or- AckAll, not just AckExplicit 2021-08-10 17:38:46 -04:00
Matthias Hanel
b511f3fd7a fixed unit test to require fc export as well 
Signed-off-by: Matthias Hanel <mh@synadia.com>
 2021-08-10 14:03:44 -04:00
R.I.Pienaar
a3bbb04748 Merge pull request #2409 from ripienaar/js_errors_redux 
attempt to improve UX of the error system
 2021-08-10 20:01:24 +02:00
Derek Collison
7dd399e355 Merge branch 'main' into max-per-default 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-10 07:33:58 -07:00
R.I.Pienaar
76ab1b8d17 attempt to improve UX of the error system 
Previously we had a few confusing functions like NewT
and similar that were quite fragile to use due to minimal
validation and a panic in go stdlib string Replacer.

Now we generate helper methods for every string, these
are used to access errors, fill in templates and conditional
returns of error type using the new Unless() option

We now get compile time errors for some common mistakes
and have better IDE helpers for arguments etc

Signed-off-by: R.I.Pienaar <rip@devco.net>
 2021-08-10 16:08:28 +02:00
Derek Collison
b38c361afd Merge pull request #2427 from nats-io/bad-err 
Fix for #2423
 2021-08-10 07:03:39 -07:00
Derek Collison
cb6b397573 Fix for #2423 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-10 06:46:48 -07:00
Derek Collison
633763a202 Fix for #2420 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-10 06:36:08 -07:00
Derek Collison
29536629eb Simplified flow control, avoid stalls due to msg loss 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-09 20:13:17 -07:00
Derek Collison
8e5314b67f Fix for subscription leak. 
If an auto-unsub request was received after the subscription had already delivered more than the limit, the subscription will leak.

Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-07 16:58:25 -07:00
Derek Collison
e03c3da67c Bump version 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-07 14:38:11 -07:00
Derek Collison
7c089a423a Merge pull request #2418 from nats-io/dir-not-empty 
[FIXED] #2417
 2021-08-07 12:35:19 -07:00
Derek Collison
40c21934c5 Fix for #2416 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-06 14:58:25 -07:00
Derek Collison
b517229c32 Fix for #2417 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-06 14:44:00 -07:00
Ivan Kozlovic
ed9e6b24c2 Release v2.3.4 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2021-08-04 17:02:26 -06:00
Ivan Kozlovic
2939814999 Report the limit using MAX_PAYLOAD_MAX_SIZE instead of hardcoded in warning 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2021-08-04 16:54:31 -06:00
Ivan Kozlovic
d1365b7412 Add warning if max_payload > 8MB 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2021-08-04 16:52:17 -06:00
Ivan Kozlovic
4865dc7ae3 [CHANGED] Check that max_payload is not greater than max_pending 
This is related to PR #2407. Since the 64MB pending size is actually
configurable, we should fail only if max_payload is greater than
the configured max_pending. This is done in validateOptions() which
covers both config file and direct options in embedded cases.
The check in opts.go is reverted to max int32 since at this point
we don't know if/what max_pending will be, so we simply check
that it is not more than a int32.

For the next minor release, we could have another change that
imposes a lower limit to max_payload (regardless if max_pending
is higher).

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2021-08-04 16:33:21 -06:00
Derek Collison
bf966d84f3 Number of initial pending was off by one when DeliverLastPerSubject was utilized on a consumer. 
Signed-off-by: Derek Collison <derek@nats.io>
 2021-08-04 14:20:52 -07:00