Derek Collison 04d4f08e8c Under heavy contention skip combined with remove could result in index being stamped with underflow for number of messages. ...

We had a report of a panic on server restart with 2.8.0-beta.1. The panic was trying to malloc the size of a load block based off of the number of messages we thought the block had from the index.
Before, SkipMsg would decrement and when we added the record via writeMsgRecord we would add it back in. However we did release the lock, meaning other things could run.
If in between the decrement, say to 0 (we did protect against underflow there), then a remove and subsequent writeIndexInfo would stamp and underflow.

Signed-off-by: Derek Collison <derek@nats.io>

2022-03-26 11:05:38 -07:00

..

configs

[fixed] tls timeout now accepts units

2021-07-19 11:42:28 -04:00

pse

Travis updates

2021-11-15 17:23:08 -07:00

sysmem

Travis updates

2021-11-15 17:23:08 -07:00

accounts_test.go

improve mapping template regex to allow for some extra spaces and associated test upgrade

2022-03-10 11:30:51 -08:00

accounts.go

Merge pull request #2890 from nats-io/jnm/partition_mapping

2022-03-25 11:30:24 -07:00

auth_test.go

Reset authSet state

2022-01-21 11:03:19 -08:00

auth.go

Fixed #2810. Do not warn about password for internally generated no auth user when just system account assigned to non-default.

2022-01-21 10:09:10 -08:00

ciphersuites.go

Add TLS 1.3 (and new ciphers) in the tlsVersion output

2020-03-18 10:09:23 -06:00

client_test.go

[FIXED] A slow consumer could cause the publisher to block

2021-11-09 17:22:15 -07:00

client.go

[CHANGED] Gateway: Detect duplicate names between clusters

2022-03-15 15:00:13 -06:00

closed_conns_test.go

System Account on by default.

2020-05-29 17:56:45 -07:00

config_check_test.go

[CHANGED] Duplicates in authorization{} and accounts{} now detected

2022-03-21 19:50:16 -06:00

const.go

Bump to 2.8.0-beta.1

2022-03-24 16:52:42 -07:00

consumer.go

Fixed another possible lock inversion consumer->stream

2022-03-25 12:21:51 -06:00

dirstore_test.go

[ADDED] Allow certain consumer attributes to be updated #2670, #2603

2021-11-04 13:43:11 -07:00

dirstore.go

Make sure jwt claim update does not wipe system imports

2021-08-17 10:03:30 -07:00

disk_avail_openbsd.go

Travis updates

2021-11-15 17:23:08 -07:00

disk_avail_windows.go

Travis updates

2021-11-15 17:23:08 -07:00

disk_avail.go

Travis updates

2021-11-15 17:23:08 -07:00

errors_gen.go

fix error code for JSStreamHeaderExceedsMaximumErr

2021-09-15 09:01:03 +02:00

errors_test.go

Renaming IsErr to ErrorIs

2020-02-25 19:53:09 -05:00

errors.go

Merge pull request #2890 from nats-io/jnm/partition_mapping

2022-03-25 11:30:24 -07:00

errors.json

When a stream or consumer was offline we would not properly respond to a delete.

2022-03-15 21:11:23 -07:00

events_test.go

[FIXED] Check for no_auth_user

2021-12-14 10:00:54 -07:00

events.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

filestore_test.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

filestore.go

Under heavy contention skip combined with remove could result in index being stamped with underflow for number of messages.

2022-03-26 11:05:38 -07:00

fuzz.go

Travis updates

2021-11-15 17:23:08 -07:00

gateway_test.go

[CHANGED] Gateway: Detect duplicate names between clusters

2022-03-15 15:00:13 -06:00

gateway.go

[CHANGED] Gateway: Detect duplicate names between clusters

2022-03-15 15:00:13 -06:00

ipqueue_test.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

ipqueue.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

jetstream_api.go

Fixed data race caused by moving some code inside startGoRoutine

2022-03-25 12:51:52 -06:00

jetstream_cluster_test.go

[FIXED] JetStream: possible deadlock during consumer leadership change

2022-03-25 12:21:51 -06:00

jetstream_cluster.go

Fix update of R1 Consumer in clustered setup.

2022-03-25 14:48:15 -04:00

jetstream_errors_generated.go

When a stream or consumer was offline we would not properly respond to a delete.

2022-03-15 21:11:23 -07:00

jetstream_errors_test.go

attempt to improve UX of the error system

2021-08-10 16:08:28 +02:00

jetstream_errors.go

attempt to improve UX of the error system

2021-08-10 16:08:28 +02:00

jetstream_events.go

add domain in JS advisories

2021-05-07 19:35:46 +02:00

jetstream_test.go

Fix update of R1 Consumer in clustered setup.

2022-03-25 14:48:15 -04:00

jetstream.go

[FIXED] JetStream: possible deadlock during consumer leadership change

2022-03-25 12:21:51 -06:00

jwt_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

jwt.go

Remove dynamic account behaviors.

2022-02-04 13:32:18 -08:00

leafnode_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

leafnode.go

Adding denies $KV.>/$OBJ.> along leaf connections on differing domain (#2916)

2022-03-09 13:17:59 -05:00

log_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

log.go

JetStream Clustering WIP

2021-01-14 01:14:52 -08:00

memstore_test.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

memstore.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

monitor_sort_opts.go

lint updates

2019-05-06 15:41:38 -07:00

monitor_test.go

ensures the cluster info in jsz is sent from the leader only

2022-03-25 18:27:35 +01:00

monitor.go

ensures the cluster info in jsz is sent from the leader only

2022-03-25 18:27:35 +01:00

mqtt_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

mqtt.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

nkey_test.go

support always presenting a nonce to clients

2021-11-17 15:19:00 +01:00

nkey.go

support always presenting a nonce to clients

2021-11-17 15:19:00 +01:00

norace_test.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

ocsp.go

Add support for designated OCSP responders

2021-11-16 13:33:44 -08:00

opts_test.go

Update test to capture accounts{} and single u/p or token

2022-03-22 10:29:11 -06:00

opts.go

Merge pull request #2890 from nats-io/jnm/partition_mapping

2022-03-25 11:30:24 -07:00

parser_test.go

[CHANGED] Enforce max_control_line for client connections only

2021-01-26 15:33:39 -07:00

parser.go

Reset authSet state

2022-01-21 11:03:19 -08:00

ping_test.go

Fixed TestPing test

2020-06-12 10:03:47 -06:00

raft_test.go

[FIXED] Corrupted headers receiving from consumer with meta-only

2021-12-01 10:50:15 -07:00

raft.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

rate_counter_test.go

[ADDED] TLS connection rate limiter

2022-01-11 16:57:19 +02:00

rate_counter.go

[ADDED] TLS connection rate limiter

2022-01-11 16:57:19 +02:00

reload_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

reload.go

Js leaf deny (#2693)

2021-12-16 16:53:20 -05:00

ring_test.go

ring buffer test

2018-10-06 14:06:14 -07:00

ring.go

Adding an option to include subscription details in monitoring responses.

2020-03-23 12:25:51 -04:00

route.go

[CHANGED] Gateway: Detect duplicate names between clusters

2022-03-15 15:00:13 -06:00

routes_test.go

Ensure file path is correct during stream restore

2022-03-09 13:31:51 -07:00

sendq.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

server_test.go

Changes to IPQueues

2022-03-17 17:53:06 -06:00

server.go

[FIXED] Server version check

2022-03-25 12:11:55 -06:00

service_test.go

Travis updates

2021-11-15 17:23:08 -07:00

service_windows.go

Shutdown on Ctrl+C

2019-11-14 20:05:32 -07:00

service.go

Travis updates

2021-11-15 17:23:08 -07:00

signal_test.go

Travis updates

2021-11-15 17:23:08 -07:00

signal_windows.go

Handle SIGTERM on windows

2021-09-01 14:55:26 -07:00

signal.go

Travis updates

2021-11-15 17:23:08 -07:00

split_test.go

Refactor async client tests

2019-12-12 11:58:24 -07:00

store.go

Improve memory usage through JetStream storage layer.

2022-03-24 17:45:15 -06:00

stream.go

[FIXED] JetStream: possible deadlock during consumer leadership change

2022-03-25 12:21:51 -06:00

sublist_test.go

Js leaf deny (#2693)

2021-12-16 16:53:20 -05:00

sublist.go

fixed queue group memory leak

2021-09-13 15:22:05 +03:00

test_test.go

[ADDED] Allow certain consumer attributes to be updated #2670, #2603

2021-11-04 13:43:11 -07:00

trust_test.go

Check errors when removing test directories and files

2021-04-07 11:09:47 -07:00

util_test.go

[FIXED] Server version check

2022-03-25 12:11:55 -06:00

util.go

[FIXED] Server version check

2022-03-25 12:11:55 -06:00

websocket_test.go

Add X-Forwarded-For IP to the client's remote address

2022-01-03 11:56:12 -07:00

websocket.go

[ADDED] MQTT: Support for Websocket

2021-12-06 16:13:13 -07:00