mirror of
https://github.com/gogrlx/nats-server.git
synced 2026-04-16 11:04:42 -07:00
6460519cf5
If a client with a given client ID is connected and while connected another client tries to reuse the same client ID, the spec says that the old client be closed and the new one accepted. However, the server protects from this flapping happening all the time by rejecting new clients that try to connect at a very fast pace. However, the server was closing a misbehaving client after a second delay (to prevent immediate reconnect if the client library does that) but was not blocking the read loop and the compounding issue was that if that misbehaving client is REALLY misbehaving and not waiting for the CONNACK to send more protocols (for instance SUB) the server would panic because the client was not fully configured. To prevent that, the server will now "block" this misbehaving client in its readLoop before closing the connection, preventing processing of possible protocols that follow the CONNECT. Resolves #3313 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Tests
Tests that run on Travis have been split into jobs that run in their own VM in parallel. This reduces the overall running time but also is allowing recycling of a job when we get a flapper as opposed to have to recycle the whole test suite.
JetStream Tests
For JetStream tests, we need to observe a naming convention so that no tests are omitted when running on Travis.
The script runTestsOnTravis.sh will run a given job based on the definition found in ".travis.yml".
As for the naming convention:
- All JetStream tests name should start with
TestJetStream - Cluster tests should go into
jetstream_cluster_test.goand start withTestJetStreamCluster - Super-cluster tests should go into
jetstream_super_cluster_test.goand start withTestJetStreamSuperCluster
Not following this convention means that some tests may not be executed on Travis.