mirror of
https://github.com/gogrlx/nats-server.git
synced 2026-04-02 11:48:43 -07:00
3977ea04f5
The panic was caused by the closing of an already closed Go channel. The Delete() relied on the consumer's mset being nil to consider the consumer already closed. However, the consumer's mset is set to nil after invoking sendDeleteAdvisoryLocked() which internally invokes sendAdvisory() which releases/reacquires the consumer lock. This left an open door for a race to occur and Delete() to be invoked twice on the same consumer. Moving setting the consumer's mset to nil too early would prevent the sendAdvisory() to actually do its job. We could pass the mset to sendAvisory(), but a simpler approach is to simply use a "closed" boolean on the Consumer object that is set to true at the beginning of the Delete() function. Resolves #1621 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>