gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-14 02:07:59 -07:00
Code Issues Packages Projects Releases Wiki Activity
Files
e06e0a247fe7bbf2a4462c90f359cd975d2d47c6
nats-server/server
History
Ivan Kozlovic 1ba617bba0 Fixed data race with RAFT node election timer 
Got this race:
```
==================
WARNING: DATA RACE
Read at 0x00c001c880e8 by goroutine 342:
  github.com/nats-io/nats-server/v2/server.(*raft).resetElect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1525 +0x44
  github.com/nats-io/nats-server/v2/server.(*raft).resetElectionTimeout()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1520 +0xa4
  github.com/nats-io/nats-server/v2/server.(*raft).handleAppendEntry()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:2537 +0x12e
  github.com/nats-io/nats-server/v2/server.(*raft).handleAppendEntry-fm()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:2525 +0xcc
...

Previous write at 0x00c001c880e8 by goroutine 587:
  github.com/nats-io/nats-server/v2/server.(*raft).resetElect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1526 +0x113
  github.com/nats-io/nats-server/v2/server.(*raft).resetElectionTimeout()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1520 +0xa4
  github.com/nats-io/nats-server/v2/server.(*Server).startRaftNode()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:484 +0x20d1
  github.com/nats-io/nats-server/v2/server.(*jetStream).createRaftGroup()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/jetstream_cluster.go:1497 +0x9ed
  github.com/nats-io/nats-server/v2/server.(*jetStream).processClusterCreateConsumer()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/jetstream_cluster.go:3063 +0xba4
...

==================
WARNING: DATA RACE
Read at 0x00c0006671f0 by goroutine 342:
  time.(*Timer).Stop()
      /usr/local/go/src/time/sleep.go:78 +0x84
  github.com/nats-io/nats-server/v2/server.(*raft).resetElect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1528 +0x58
  github.com/nats-io/nats-server/v2/server.(*raft).resetElectionTimeout()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1520 +0xa4
  github.com/nats-io/nats-server/v2/server.(*raft).handleAppendEntry()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:2537 +0x12e
  github.com/nats-io/nats-server/v2/server.(*raft).handleAppendEntry-fm()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:2525 +0xcc
...

Previous write at 0x00c0006671f0 by goroutine 587:
  time.NewTimer()
      /usr/local/go/src/time/sleep.go:92 +0xb3
  github.com/nats-io/nats-server/v2/server.(*raft).resetElect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1526 +0x104
  github.com/nats-io/nats-server/v2/server.(*raft).resetElectionTimeout()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:1520 +0xa4
  github.com/nats-io/nats-server/v2/server.(*Server).startRaftNode()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/raft.go:484 +0x20d1
  github.com/nats-io/nats-server/v2/server.(*jetStream).createRaftGroup()
      /Users/ivan/dev/go/src/github.com/nats-io/nats-server/server/jetstream_cluster.go:1497 +0x9ed
...
```

Looked at all places where resetElect() or resetElectionTimeout() was invoked without
being protected by the raft's lock and added it.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-04-12 18:56:28 -06:00
..
configs
[fixed] tls timeout now accepts units
2021-07-19 11:42:28 -04:00
pse
Travis updates
2021-11-15 17:23:08 -07:00
sysmem
Travis updates
2021-11-15 17:23:08 -07:00
accounts_test.go
improve mapping template regex to allow for some extra spaces and associated test upgrade
2022-03-10 11:30:51 -08:00
accounts.go
returns -1 for new unlimited/unset limits and tests/fixes info counts (#3002)
2022-04-05 12:25:55 -04:00
auth_test.go
Reset authSet state
2022-01-21 11:03:19 -08:00
auth.go
Fixed #2810. Do not warn about password for internally generated no auth user when just system account assigned to non-default.
2022-01-21 10:09:10 -08:00
ciphersuites.go
Add TLS 1.3 (and new ciphers) in the tlsVersion output
2020-03-18 10:09:23 -06:00
client_test.go
[FIXED] A slow consumer could cause the publisher to block
2021-11-09 17:22:15 -07:00
client.go
[FIXED] subject renaming with hand crafted reply subject (#3026)
2022-04-11 22:32:02 -04:00
closed_conns_test.go
System Account on by default.
2020-05-29 17:56:45 -07:00
config_check_test.go
Reject configuration with value below 2.8.0
2022-04-07 12:49:34 -06:00
const.go
Bump to version 2.8.0-beta.15
2022-04-12 17:50:21 -06:00
consumer.go
Merge pull request #3020 from nats-io/move-updates
2022-04-11 17:33:13 -07:00
dirstore_test.go
In Merge validate nkey and subsequent saveIfNewer error on invalid jwt (#2985)
2022-03-31 14:25:25 -04:00
dirstore.go
In Merge validate nkey and subsequent saveIfNewer error on invalid jwt (#2985)
2022-03-31 14:25:25 -04:00
disk_avail_openbsd.go
Travis updates
2021-11-15 17:23:08 -07:00
disk_avail_windows.go
Travis updates
2021-11-15 17:23:08 -07:00
disk_avail.go
Travis updates
2021-11-15 17:23:08 -07:00
errors_gen.go
fix error code for JSStreamHeaderExceedsMaximumErr
2021-09-15 09:01:03 +02:00
errors_test.go
Renaming IsErr to ErrorIs
2020-02-25 19:53:09 -05:00
errors.go
[ADDED] LeafNode min_version new option
2022-04-06 18:40:33 -06:00
errors.json
Disallow moving a stream that is already being moved
2022-04-07 17:09:55 -07:00
events_test.go
[FIXED] Check for no_auth_user
2021-12-14 10:00:54 -07:00
events.go
Allow assets such as streams and their associated consumers to migrate between clusters.
2022-04-04 18:28:36 -07:00
filestore_test.go
Fixed data race and some flappers
2022-03-31 10:05:34 -06:00
filestore.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
fuzz.go
Travis updates
2021-11-15 17:23:08 -07:00
gateway_test.go
Fixed some data race and some flappers
2022-03-29 19:02:41 -06:00
gateway.go
Fixed some data race and some flappers
2022-03-29 19:02:41 -06:00
ipqueue_test.go
Changes to IPQueues
2022-03-17 17:53:06 -06:00
ipqueue.go
Changes to IPQueues
2022-03-17 17:53:06 -06:00
jetstream_api.go
Don't set domain here
2022-04-11 20:52:22 -07:00
jetstream_cluster_test.go
Move test to no race, rename others
2022-04-12 16:23:36 -07:00
jetstream_cluster.go
Only wipe on certain errors and always resume
2022-04-12 15:50:37 -07:00
jetstream_errors_generated.go
Disallow moving a stream that is already being moved
2022-04-07 17:09:55 -07:00
jetstream_errors_test.go
attempt to improve UX of the error system
2021-08-10 16:08:28 +02:00
jetstream_errors.go
attempt to improve UX of the error system
2021-08-10 16:08:28 +02:00
jetstream_events.go
add domain in JS advisories
2021-05-07 19:35:46 +02:00
jetstream_test.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
jetstream.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
jwt_test.go
fix sleep in unit test to ensure updates have propagated (#3012)
2022-04-07 12:16:18 -04:00
jwt.go
Remove dynamic account behaviors.
2022-02-04 13:32:18 -08:00
leafnode_test.go
Reject configuration with value below 2.8.0
2022-04-07 12:49:34 -06:00
leafnode.go
Reject configuration with value below 2.8.0
2022-04-07 12:49:34 -06:00
log_test.go
Ensure file path is correct during stream restore
2022-03-09 13:31:51 -07:00
log.go
Some changes based on review
2022-04-01 17:55:33 -06:00
memstore_test.go
Improve memory usage through JetStream storage layer.
2022-03-24 17:45:15 -06:00
memstore.go
Add consumerMemStore impl to allow proper replication of state.
2022-04-10 08:01:13 -07:00
monitor_sort_opts.go
…
monitor_test.go
[ADDED] Monitoring: MQTT and Websocket blocks in /varz endpoint
2022-04-04 10:11:55 -06:00
monitor.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
mqtt_test.go
[ADDED] Tiered limits and fix limit issues on updates (#2945)
2022-03-28 20:47:54 -04:00
mqtt.go
Changes to IPQueues
2022-03-17 17:53:06 -06:00
nkey_test.go
support always presenting a nonce to clients
2021-11-17 15:19:00 +01:00
nkey.go
support always presenting a nonce to clients
2021-11-17 15:19:00 +01:00
norace_test.go
Move test to no race, rename others
2022-04-12 16:23:36 -07:00
ocsp.go
Add support for designated OCSP responders
2021-11-16 13:33:44 -08:00
opts_test.go
Update test to capture accounts{} and single u/p or token
2022-03-22 10:29:11 -06:00
opts.go
Adding unique_tag to ensure matching tags are not used twice (#3011)
2022-04-07 18:11:00 -04:00
parser_test.go
[CHANGED] Enforce max_control_line for client connections only
2021-01-26 15:33:39 -07:00
parser.go
Reset authSet state
2022-01-21 11:03:19 -08:00
ping_test.go
Fixed TestPing test
2020-06-12 10:03:47 -06:00
raft_test.go
fix unit test that did not fail when header was modified (#3000)
2022-04-04 19:24:09 -04:00
raft.go
Fixed data race with RAFT node election timer
2022-04-12 18:56:28 -06:00
rate_counter_test.go
[ADDED] TLS connection rate limiter
2022-01-11 16:57:19 +02:00
rate_counter.go
[ADDED] TLS connection rate limiter
2022-01-11 16:57:19 +02:00
reload_test.go
Ensure file path is correct during stream restore
2022-03-09 13:31:51 -07:00
reload.go
We were not accounting for some newer internal clients (JETSTREAM, ACCOUNT, etc) when reloading authorization, etc.
2022-03-30 19:12:18 -07:00
ring_test.go
…
ring.go
Adding an option to include subscription details in monitoring responses.
2020-03-23 12:25:51 -04:00
route.go
[CHANGED] Gateway: Detect duplicate names between clusters
2022-03-15 15:00:13 -06:00
routes_test.go
[FIXED] subject renaming with hand crafted reply subject (#3026)
2022-04-11 22:32:02 -04:00
sendq.go
Changes to IPQueues
2022-03-17 17:53:06 -06:00
server_test.go
[CHANGED] Rate limit similar warnings
2022-04-01 15:24:03 -06:00
server.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
service_test.go
Travis updates
2021-11-15 17:23:08 -07:00
service_windows.go
…
service.go
Travis updates
2021-11-15 17:23:08 -07:00
signal_test.go
Travis updates
2021-11-15 17:23:08 -07:00
signal_windows.go
Handle SIGTERM on windows
2021-09-01 14:55:26 -07:00
signal.go
Travis updates
2021-11-15 17:23:08 -07:00
split_test.go
…
store.go
Add consumerMemStore impl to allow proper replication of state.
2022-04-10 08:01:13 -07:00
stream.go
[FIXED] JetStream stream catchup issues
2022-04-12 16:05:12 -06:00
sublist_test.go
Js leaf deny (#2693)
2021-12-16 16:53:20 -05:00
sublist.go
fixed queue group memory leak
2021-09-13 15:22:05 +03:00
test_test.go
[ADDED] Allow certain consumer attributes to be updated #2670, #2603
2021-11-04 13:43:11 -07:00
trust_test.go
Check errors when removing test directories and files
2021-04-07 11:09:47 -07:00
util_test.go
[FIXED] Server version check
2022-03-25 12:11:55 -06:00
util.go
Reject configuration with value below 2.8.0
2022-04-07 12:49:34 -06:00
websocket_test.go
Add X-Forwarded-For IP to the client's remote address
2022-01-03 11:56:12 -07:00
websocket.go
[ADDED] MQTT: Support for Websocket
2021-12-06 16:13:13 -07:00