From 6032f55925c6c7bd3006b125d4c35a3ac10fccc4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sat, 28 Feb 2026 06:55:21 +0000 Subject: [PATCH] Fix DNF isHeld to reuse listHeld instead of passing pkg to versionlock list Co-authored-by: taigrr <8261498+taigrr@users.noreply.github.com> --- dnf/capabilities_linux.go | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/dnf/capabilities_linux.go b/dnf/capabilities_linux.go index 5186fd0..2370ffb 100644 --- a/dnf/capabilities_linux.go +++ b/dnf/capabilities_linux.go @@ -114,18 +114,11 @@ func listHeld(ctx context.Context, v5 bool) ([]snack.Package, error) { } func isHeld(ctx context.Context, pkg string, v5 bool) (bool, error) { - out, err := run(ctx, []string{"versionlock", "list", pkg}, snack.Options{}) + held, err := listHeld(ctx, v5) if err != nil { - // versionlock list exits non-zero when no match is found on some versions - return false, nil + return false, err } - var pkgs []snack.Package - if v5 { - pkgs = parseVersionLockDNF5(out) - } else { - pkgs = parseVersionLock(out) - } - for _, p := range pkgs { + for _, p := range held { if p.Name == pkg { return true, nil }