mirror of
https://github.com/gogrlx/snack.git
synced 2026-04-02 05:08:42 -07:00
test: exhaustive unit tests for all provider-specific interfaces
Add 740 total tests (up from ~200) covering: - Compile-time interface compliance for all providers - GetCapabilities assertions for every provider - Parse function edge cases: empty, malformed, single-entry, multi-entry - apt: extract inline parse logic into testable functions (parsePolicyCandidate, parseUpgradeSimulation, parseHoldList, parseOwner, parseSourcesLine) - dnf/rpm: edge cases for both dnf4 and dnf5 parsers, normalize/parseArch - pacman/aur: parseUpgrades, parseGroupPkgSet, capabilities - apk: parseUpgradeSimulation, parseListLine, SupportsDryRun - flatpak/snap: semverCmp, stripNonNumeric edge cases - pkg/ports: all parse functions with thorough edge cases Every provider now has: - Interface compliance checks (what it implements AND what it doesn't) - Capabilities test via snack.GetCapabilities() - Parse function unit tests with table-driven edge cases
This commit is contained in:
140
aur/aur_test.go
140
aur/aur_test.go
@@ -3,7 +3,9 @@ package aur
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/gogrlx/snack"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestParsePackageList(t *testing.T) {
|
||||
@@ -63,3 +65,141 @@ func TestNewWithOptions(t *testing.T) {
|
||||
assert.Equal(t, "/tmp/aur-builds", a.BuildDir)
|
||||
assert.Equal(t, []string{"--skippgpcheck", "--nocheck"}, a.MakepkgFlags)
|
||||
}
|
||||
|
||||
func TestInterfaceCompliance(t *testing.T) {
|
||||
var _ snack.Manager = (*AUR)(nil)
|
||||
var _ snack.VersionQuerier = (*AUR)(nil)
|
||||
var _ snack.Cleaner = (*AUR)(nil)
|
||||
var _ snack.PackageUpgrader = (*AUR)(nil)
|
||||
}
|
||||
|
||||
func TestInterfaceNonCompliance(t *testing.T) {
|
||||
a := New()
|
||||
var m snack.Manager = a
|
||||
|
||||
if _, ok := m.(snack.FileOwner); ok {
|
||||
t.Error("AUR should not implement FileOwner")
|
||||
}
|
||||
if _, ok := m.(snack.Holder); ok {
|
||||
t.Error("AUR should not implement Holder")
|
||||
}
|
||||
if _, ok := m.(snack.RepoManager); ok {
|
||||
t.Error("AUR should not implement RepoManager")
|
||||
}
|
||||
if _, ok := m.(snack.KeyManager); ok {
|
||||
t.Error("AUR should not implement KeyManager")
|
||||
}
|
||||
if _, ok := m.(snack.Grouper); ok {
|
||||
t.Error("AUR should not implement Grouper")
|
||||
}
|
||||
if _, ok := m.(snack.NameNormalizer); ok {
|
||||
t.Error("AUR should not implement NameNormalizer")
|
||||
}
|
||||
if _, ok := m.(snack.DryRunner); ok {
|
||||
t.Error("AUR should not implement DryRunner")
|
||||
}
|
||||
}
|
||||
|
||||
func TestCapabilities(t *testing.T) {
|
||||
caps := snack.GetCapabilities(New())
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
got bool
|
||||
want bool
|
||||
}{
|
||||
{"VersionQuery", caps.VersionQuery, true},
|
||||
{"Clean", caps.Clean, true},
|
||||
{"FileOwnership", caps.FileOwnership, false},
|
||||
{"Hold", caps.Hold, false},
|
||||
{"RepoManagement", caps.RepoManagement, false},
|
||||
{"KeyManagement", caps.KeyManagement, false},
|
||||
{"Groups", caps.Groups, false},
|
||||
{"NameNormalize", caps.NameNormalize, false},
|
||||
{"DryRun", caps.DryRun, false},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
if tt.got != tt.want {
|
||||
t.Errorf("%s = %v, want %v", tt.name, tt.got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestName(t *testing.T) {
|
||||
a := New()
|
||||
assert.Equal(t, "aur", a.Name())
|
||||
}
|
||||
|
||||
func TestParsePackageList_EdgeCases(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
input string
|
||||
wantLen int
|
||||
wantNames []string
|
||||
wantVers []string
|
||||
}{
|
||||
{
|
||||
name: "empty string",
|
||||
input: "",
|
||||
wantLen: 0,
|
||||
},
|
||||
{
|
||||
name: "whitespace only",
|
||||
input: " \n\t\n \n",
|
||||
wantLen: 0,
|
||||
},
|
||||
{
|
||||
name: "single package",
|
||||
input: "yay 12.5.7-1\n",
|
||||
wantLen: 1,
|
||||
wantNames: []string{"yay"},
|
||||
wantVers: []string{"12.5.7-1"},
|
||||
},
|
||||
{
|
||||
name: "malformed single field",
|
||||
input: "orphan\n",
|
||||
wantLen: 0,
|
||||
},
|
||||
{
|
||||
name: "malformed mixed with valid",
|
||||
input: "orphan\nyay 12.5.7-1\nbadline\nparu 2.0-1\n",
|
||||
wantLen: 2,
|
||||
wantNames: []string{"yay", "paru"},
|
||||
wantVers: []string{"12.5.7-1", "2.0-1"},
|
||||
},
|
||||
{
|
||||
name: "extra fields ignored",
|
||||
input: "yay 12.5.7-1 extra stuff\n",
|
||||
wantLen: 1,
|
||||
wantNames: []string{"yay"},
|
||||
wantVers: []string{"12.5.7-1"},
|
||||
},
|
||||
{
|
||||
name: "trailing and leading whitespace on lines",
|
||||
input: " yay 12.5.7-1 \n paru 2.0.4-1\n\n",
|
||||
wantLen: 2,
|
||||
wantNames: []string{"yay", "paru"},
|
||||
wantVers: []string{"12.5.7-1", "2.0.4-1"},
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
pkgs := parsePackageList(tt.input)
|
||||
require.Len(t, pkgs, tt.wantLen)
|
||||
for i, p := range pkgs {
|
||||
assert.Equal(t, "aur", p.Repository, "all packages should have Repository=aur")
|
||||
assert.True(t, p.Installed, "all packages should have Installed=true")
|
||||
if i < len(tt.wantNames) {
|
||||
assert.Equal(t, tt.wantNames[i], p.Name)
|
||||
}
|
||||
if i < len(tt.wantVers) {
|
||||
assert.Equal(t, tt.wantVers[i], p.Version)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user