taigrr/bitcask
1
0
Fork 0
mirror of https://github.com/taigrr/bitcask synced 2025-01-18 04:03:17 -08:00
Code Issues Projects Releases Wiki Activity

Save metadata on Sync (#197)

Browse Source 
* Save metadata on Sync

* Add test
This commit is contained in:
Haleem Assal 2020-12-14 16:32:48 -04:00 committed by GitHub
parent 3a6235ea03
commit 29e1cf648b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bitcask.go
View File

@ -125,6 +125,11 @@ func (b *Bitcask) close() error {
func (b *Bitcask) Sync() error { func (b *Bitcask) Sync() error {
b.mu.RLock() b.mu.RLock()
defer b.mu.RUnlock() defer b.mu.RUnlock()
if err := b.saveMetadata(); err != nil {
return err
}
return b.curr.Sync() return b.curr.Sync()
} }
@ -201,12 +206,7 @@ func (b *Bitcask) Put(key, value []byte) error {
} }
// in case of successful `put`, IndexUpToDate will be always be false // in case of successful `put`, IndexUpToDate will be always be false
if b.metadata.IndexUpToDate { b.metadata.IndexUpToDate = false
b.metadata.IndexUpToDate = false
if err := b.saveMetadata(); err != nil {
return err
}
}
if oldItem, found := b.trie.Search(key); found { if oldItem, found := b.trie.Search(key); found {
b.metadata.ReclaimableSpace += oldItem.(internal.Item).Size b.metadata.ReclaimableSpace += oldItem.(internal.Item).Size

5
bitcask_test.go
View File

@ -633,6 +633,11 @@ func TestSync(t *testing.T) {
value := []byte("foobar") value := []byte("foobar")
err = db.Put(key, value) err = db.Put(key, value)
}) })
t.Run("Put", func(t *testing.T) {
err = db.Put([]byte("hello"), []byte("world"))
assert.NoError(err)
})
} }
func TestMaxKeySize(t *testing.T) { func TestMaxKeySize(t *testing.T) {