From 643e578585bfd16a9c30641294479403808dc2f9 Mon Sep 17 00:00:00 2001 From: shiniao Date: Thu, 29 Oct 2020 19:47:08 +0800 Subject: [PATCH] Refactored Save function for config (#179) * Refactored Save function for config * Refactored Save function for config --- AUTHORS | 1 + internal/config/config.go | 16 ++++------------ 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/AUTHORS b/AUTHORS index 94175d2..6f38876 100644 --- a/AUTHORS +++ b/AUTHORS @@ -10,6 +10,7 @@ James Mills Jesse Donat Kebert Xela kebertxela panyun panyun +shiniao Whemoon Jang Yury Fedorov orlangure o2gy84 diff --git a/internal/config/config.go b/internal/config/config.go index 136facc..2e870c7 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -3,7 +3,6 @@ package config import ( "encoding/json" "io/ioutil" - "os" ) // Config contains the bitcask configuration parameters @@ -33,23 +32,16 @@ func Load(path string) (*Config, error) { // Save saves the configuration to the provided path func (c *Config) Save(path string) error { - f, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0600) - if err != nil { - return err - } data, err := json.Marshal(c) if err != nil { return err } - if _, err = f.Write(data); err != nil { + err = ioutil.WriteFile(path, data, 0600) + if err != nil { return err } - - if err = f.Sync(); err != nil { - return err - } - - return f.Close() + + return nil }