taigrr/bitcask
1
0
Fork 0
mirror of https://github.com/taigrr/bitcask synced 2025-01-18 04:03:17 -08:00
Code Issues Projects Releases Wiki Activity

Fix a race condition around .Close() and .Sync()

Browse Source
This commit is contained in:
James Mills 2020-11-17 19:30:44 +10:00
parent e900e2fa77
commit 720f03c6c2
No known key found for this signature in database
GPG Key ID: AC4C014F1440EBD6
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bitcask.go
View File

@ -87,7 +87,10 @@ func (b *Bitcask) Stats() (stats Stats, err error) {
// Close() as this is the only way to cleanup the lock held by the open // Close() as this is the only way to cleanup the lock held by the open
// database. // database.
func (b *Bitcask) Close() error { func (b *Bitcask) Close() error {
b.mu.RLock()
defer func() { defer func() {
b.mu.RUnlock()
b.Flock.Unlock() b.Flock.Unlock()
os.Remove(b.Flock.Path()) os.Remove(b.Flock.Path())
}() }()
@ -107,6 +110,8 @@ func (b *Bitcask) Close() error {
// Sync flushes all buffers to disk ensuring all data is written // Sync flushes all buffers to disk ensuring all data is written
func (b *Bitcask) Sync() error { func (b *Bitcask) Sync() error {
b.mu.RLock()
defer b.mu.RUnlock()
return b.curr.Sync() return b.curr.Sync()
} }