taigrr/bitcask
1
0
Fork 0
mirror of https://github.com/taigrr/bitcask synced 2025-01-18 04:03:17 -08:00
Code Issues Projects Releases Wiki Activity

Improve read performance by ~6x for active Datafile by not reopening it each time

Browse Source
This commit is contained in:
James Mills 2019-03-13 07:41:00 +10:00
parent 4b52dea172
commit 904f6b19a0
No known key found for this signature in database
GPG Key ID: AC4C014F1440EBD6
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
bitcask.go
View File

@ -43,11 +43,22 @@ func (b *Bitcask) Get(key string) ([]byte, error) {
return nil, ErrKeyNotFound return nil, ErrKeyNotFound
} }
df, err := NewDatafile(b.path, item.FileID, true) var (
if err != nil { df *Datafile
return nil, err err error
)
// Optimization
if item.FileID == b.curr.id {
df = b.curr
} else {
// TODO: Pre-open non-active Datafiles and cache the file pointers?
df, err = NewDatafile(b.path, item.FileID, true)
if err != nil {
return nil, err
}
defer df.Close()
} }
defer df.Close()
e, err := df.ReadAt(item.Index) e, err := df.ReadAt(item.Index)
if err != nil { if err != nil {