From 2d602a1244dac524b3baa19cf403fff7a5d343f7 Mon Sep 17 00:00:00 2001 From: Kiyon Date: Mon, 5 Apr 2021 14:27:56 +0800 Subject: [PATCH] Remove redundant lock in listen --- standard_renderer.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/standard_renderer.go b/standard_renderer.go index 2c8a8ee..a96d9db 100644 --- a/standard_renderer.go +++ b/standard_renderer.go @@ -65,7 +65,7 @@ func (r *standardRenderer) start() { func (r *standardRenderer) stop() { r.flush() clearLine(r.out) - r.done <- struct{}{} + close(r.done) } // listen waits for ticks on the ticker, or a signal to stop the renderer. @@ -77,11 +77,8 @@ func (r *standardRenderer) listen() { r.flush() } case <-r.done: - r.mtx.Lock() r.ticker.Stop() r.ticker = nil - r.mtx.Unlock() - close(r.done) return } }