From 0e0b3516a6a8750728a69630bd45864e88aa5af3 Mon Sep 17 00:00:00 2001 From: timdufrane Date: Tue, 15 Jul 2014 12:29:06 -0400 Subject: [PATCH] Fix error handling in AddHandler Added correct return values so that errors can be handled. Closes #2. --- fastping.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fastping.go b/fastping.go index 0e9a5c4..e11e927 100644 --- a/fastping.go +++ b/fastping.go @@ -130,14 +130,16 @@ func (p *Pinger) AddHandler(event string, handler interface{}) error { case "receive": if hdl, ok := handler.(func(*net.IPAddr, time.Duration)); ok { p.handlers[event] = hdl + return nil } else { - errors.New(fmt.Sprintf("Receive event handler should be `func(*net.IPAddr, time.Duration)`")) + return errors.New(fmt.Sprintf("Receive event handler should be `func(*net.IPAddr, time.Duration)`")) } case "idle": if hdl, ok := handler.(func()); ok { p.handlers[event] = hdl + return nil } else { - errors.New(fmt.Sprintf("Idle event handler should be `func()`")) + return errors.New(fmt.Sprintf("Idle event handler should be `func()`")) } } return errors.New(fmt.Sprintf("No such event: %s", event))