From 64249bf8e6f06a88781b560f420e5bac6ef9a6a2 Mon Sep 17 00:00:00 2001
From: Tai Groot <tai@taigrr.com>
Date: Sat, 15 May 2021 18:13:53 -0700
Subject: [PATCH] Adds more tests for GetStartTime

---
 helpers_test.go | 88 +++++++++++++++++++++++++++++++++++++++++++++++++
 systemctl.go    |  1 +
 2 files changed, 89 insertions(+)
 create mode 100644 helpers_test.go

diff --git a/helpers_test.go b/helpers_test.go
new file mode 100644
index 0000000..8289f01
--- /dev/null
+++ b/helpers_test.go
@@ -0,0 +1,88 @@
+package systemctl
+
+import (
+	"context"
+	"fmt"
+	"testing"
+	"time"
+)
+
+// Testing assumptions
+// - there's no unit installed named `nonexistant`
+// - the syncthing unit to be available on the tester's system.
+//   this is just what was available on mine, should you want to change it,
+//   either to something in this repo or more common, feel free to submit a PR.
+// - your 'user' isn't root
+// - your user doesn't have a PolKit rule allowing access to configure nginx
+
+func TestGetStartTime(t *testing.T) {
+	testCases := []struct {
+		unit      string
+		err       error
+		opts      Options
+		runAsUser bool
+	}{
+		// Run these tests only as a user
+
+		//try nonexistant unit in user mode as user
+		{"nonexistant", ErrUnitNotRunning, Options{usermode: false}, true},
+		// try existing unit in user mode as user
+		{"syncthing", ErrUnitNotRunning, Options{usermode: true}, true},
+		// try existing unit in system mode as user
+		{"nginx", nil, Options{usermode: false}, true},
+
+		// Run these tests only as a superuser
+
+		// try nonexistant unit in system mode as system
+		{"nonexistant", ErrUnitNotRunning, Options{usermode: false}, false},
+		// try existing unit in system mode as system
+		{"nginx", ErrBusFailure, Options{usermode: true}, false},
+		// try existing unit in system mode as system
+		{"nginx", nil, Options{usermode: false}, false},
+	}
+	for _, tc := range testCases {
+		t.Run(fmt.Sprintf("%s as %s", tc.unit, userString), func(t *testing.T) {
+			if (userString == "root" || userString == "system") && tc.runAsUser {
+				t.Skip("skipping user test while running as superuser")
+			} else if (userString != "root" && userString != "system") && !tc.runAsUser {
+				t.Skip("skipping superuser test while running as user")
+			}
+			ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+			defer cancel()
+			_, err := GetStartTime(ctx, tc.unit, tc.opts)
+			if err != tc.err {
+				t.Errorf("error is %v, but should have been %v", err, tc.err)
+			}
+		})
+	}
+	// Prove start time changes after a restart
+	t.Run(fmt.Sprintf("Prove start time changes"), func(t *testing.T) {
+		if userString != "root" && userString != "system" {
+			t.Skip("skipping superuser test while running as user")
+		}
+
+		ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
+		defer cancel()
+		startTime, err := GetStartTime(ctx, "nginx", Options{usermode: false})
+		if err != nil {
+			t.Errorf("issue getting start time of nginx: %v", err)
+		}
+		err = Restart(ctx, "nginx", Options{usermode: false})
+		if err != nil {
+			t.Errorf("issue restarting nginx as %s: %v", userString, err)
+		}
+		newStartTime, err := GetStartTime(ctx, "nginx", Options{usermode: false})
+		if err != nil {
+			t.Errorf("issue getting second start time of nginx: %v", err)
+		}
+		diff := newStartTime.Sub(startTime).Seconds()
+		if diff <= 0 {
+			t.Errorf("Expected start diff to be positive, but got: %d", int(diff))
+		}
+	})
+
+}
+
+// GetStartTime(ctx context.Context, unit string, opts Options) (time.Time, error) {
+// GetMemoryUsage(ctx context.Context, unit string, opts Options) (int, error) {
+// GetPID(ctx context.Context, unit string, opts Options) (int, error) {
diff --git a/systemctl.go b/systemctl.go
index b81f818..6b5e593 100644
--- a/systemctl.go
+++ b/systemctl.go
@@ -125,6 +125,7 @@ func Show(ctx context.Context, unit string, property properties.Property, opts O
 	}
 	stdout, _, _, err := execute(ctx, args)
 	stdout = strings.TrimPrefix(stdout, string(property)+"=")
+	stdout = strings.TrimSuffix(stdout, "\n")
 	return stdout, err
 }