From 2d1b2c0947f6145cceb769d0c4dd4dd2c3be7fec Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Sun, 28 Feb 2021 15:29:15 +1100 Subject: [PATCH] Guard app signing --- v2/pkg/commands/build/packager_darwin.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/v2/pkg/commands/build/packager_darwin.go b/v2/pkg/commands/build/packager_darwin.go index 127d37ae..fcd6c3ea 100644 --- a/v2/pkg/commands/build/packager_darwin.go +++ b/v2/pkg/commands/build/packager_darwin.go @@ -55,9 +55,11 @@ func packageApplication(options *Options) error { } // Sign app if needed - err = signApplication(options) - if err != nil { - return err + if options.AppleIdentity != "" { + err = signApplication(options) + if err != nil { + return err + } } return nil @@ -188,7 +190,7 @@ func processApplicationIcon(resourceDir string, iconsDir string) (err error) { func signApplication(options *Options) error { bundlename := filepath.Join(options.BuildDirectory, options.ProjectData.Name+".app") identity := fmt.Sprintf(`"%s"`, options.AppleIdentity) - cmd := exec.Command("codesign", "--deep", "--force", "--verbose", "--sign", identity, bundlename) + cmd := exec.Command("codesign", "--sign", identity, "--deep", "--force", "--verbose", "--timestamp", "--options", "runtime", bundlename) var stdo, stde bytes.Buffer cmd.Stdout = &stdo cmd.Stderr = &stde