mirror of
https://github.com/taigrr/wasm-experiments
synced 2025-01-18 04:03:21 -08:00
Use innerText instead of innerHTML to discourage XSS risks
Roberto Clapis (@empijei) pointed out to me that using innerHTML for unformatted text is bad practice, so I've switched to using innerText and SetTextContent instead.
This commit is contained in:
parent
31e31e865c
commit
e481a67ae8
@ -16,7 +16,7 @@ type writer dom.Element
|
|||||||
// Write implements io.Writer.
|
// Write implements io.Writer.
|
||||||
func (d writer) Write(p []byte) (n int, err error) {
|
func (d writer) Write(p []byte) (n int, err error) {
|
||||||
node := dom.GetDocument().CreateElement("div")
|
node := dom.GetDocument().CreateElement("div")
|
||||||
node.SetInnerHTML(string(p))
|
node.SetTextContent(string(p))
|
||||||
(*dom.Element)(&d).AppendChild(node)
|
(*dom.Element)(&d).AppendChild(node)
|
||||||
return len(p), nil
|
return len(p), nil
|
||||||
}
|
}
|
||||||
|
BIN
html/test.wasm
BIN
html/test.wasm
Binary file not shown.
@ -14,7 +14,7 @@ func main() {
|
|||||||
div := document.Call("getElementById", "target")
|
div := document.Call("getElementById", "target")
|
||||||
|
|
||||||
node := document.Call("createElement", "div")
|
node := document.Call("createElement", "div")
|
||||||
node.Set("innerHTML", "Hello World")
|
node.Set("innerText", "Hello World")
|
||||||
|
|
||||||
div.Call("appendChild", node)
|
div.Call("appendChild", node)
|
||||||
}
|
}
|
||||||
|
@ -14,7 +14,7 @@ func main() {
|
|||||||
div := document.Get("body")
|
div := document.Get("body")
|
||||||
|
|
||||||
node := document.Call("createElement", "div")
|
node := document.Call("createElement", "div")
|
||||||
node.Set("innerHTML", "Hello jsgo.io!")
|
node.Set("innerText", "Hello jsgo.io!")
|
||||||
|
|
||||||
div.Call("appendChild", node)
|
div.Call("appendChild", node)
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user