Catch intermittent failure with HIBP module

modules/hibp/client.go

@@ -75,23 +75,23 @@ func (widget *Widget) fetchForAccount(account string, since string) (*Status, er
 }
 
 func (widget *Widget) parseResponseBody(account string, body []byte) (*Status, error) {
-	// If the body is empty then there's no breaches
+	breaches := []Breach{}
+	stat := NewStatus(account, breaches)
+
 	if len(body) == 0 {
-		stat := NewStatus(account, []Breach{})
+		// If the body is empty then there's no breaches
 		return stat, nil
 	}
 
-	// Else we have breaches for this account
-	breaches := make([]Breach, 0)
-
 	jsonErr := json.Unmarshal(body, &breaches)
 	if jsonErr != nil {
-		return nil, jsonErr
+		return stat, jsonErr
 	}
 
 	breaches = widget.filterBreaches(breaches)
+	stat.Breaches = breaches
 
-	return NewStatus(account, breaches), nil
+	return stat, nil
 }
 
 func (widget *Widget) filterBreaches(breaches []Breach) []Breach {

modules/hibp/hibp_status.go

@@ -24,5 +24,9 @@ func (stat *Status) HasBeenCompromised() bool {
 
 // Len returns the number of breaches found for the specified account
 func (stat *Status) Len() int {
+	if stat == nil || stat.Breaches == nil {
+		return 0
+	}
+
 	return len(stat.Breaches)
 }

utils/text_test.go

@@ -12,10 +12,6 @@ func Test_CenterText(t *testing.T) {
 	Equal(t, "   cat   ", CenterText("cat", 9))
 }
 
-func Test_HighlightableHelper(t *testing.T) {
-
-}
-
 func Test_RowPadding(t *testing.T) {
 	Equal(t, "", RowPadding(0, 0))
 	Equal(t, "", RowPadding(5, 2))