mirror of
https://github.com/taigrr/wtf
synced 2025-01-18 04:03:14 -08:00
WTF-657 Add spec coverage for cfg/common_settings.go (#728)
* WTF-657 Add spec coverage for cfg/common_settings.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for cfg/position_validation.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for cfg/validations.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for checklist/checklist.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for checklist/checklist_item.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for utils/conversions.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Get rid of utils.Home() function Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for utils/homedir.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Add spec coverage for utils/text.go Signed-off-by: Chris Cummer <chriscummer@me.com> * WTF-657 Clean up utils/utils.go Signed-off-by: Chris Cummer <chriscummer@me.com>
This commit is contained in:
@@ -2,8 +2,9 @@ package buildkite
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"github.com/wtfutil/wtf/utils"
|
||||
"net/http"
|
||||
|
||||
"github.com/wtfutil/wtf/utils"
|
||||
)
|
||||
|
||||
type Pipeline struct {
|
||||
@@ -61,7 +62,7 @@ func (widget *Widget) recentBuilds(pipeline PipelineSettings) ([]Build, error) {
|
||||
}
|
||||
|
||||
builds := []Build{}
|
||||
err = utils.ParseJson(&builds, resp.Body)
|
||||
err = utils.ParseJSON(&builds, resp.Body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
@@ -28,7 +28,7 @@ func (client *Client) BuildsFor() ([]*Build, error) {
|
||||
return builds, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&builds, resp.Body)
|
||||
err = utils.ParseJSON(&builds, resp.Body)
|
||||
if err != nil {
|
||||
return builds, err
|
||||
}
|
||||
|
||||
@@ -16,7 +16,7 @@ func GetMessages(roomId string, numberOfMessages int, apiToken string) ([]Messag
|
||||
return nil, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&messages, resp.Body)
|
||||
err = utils.ParseJSON(&messages, resp.Body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
@@ -32,7 +32,7 @@ func GetRoom(roomUri, apiToken string) (*Room, error) {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&rooms, resp.Body)
|
||||
err = utils.ParseJSON(&rooms, resp.Body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
@@ -19,7 +19,7 @@ func GetStories(storyType string) ([]int, error) {
|
||||
return storyIds, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&storyIds, resp.Body)
|
||||
err = utils.ParseJSON(&storyIds, resp.Body)
|
||||
if err != nil {
|
||||
return storyIds, err
|
||||
}
|
||||
@@ -36,7 +36,7 @@ func GetStory(id int) (Story, error) {
|
||||
return story, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&story, resp.Body)
|
||||
err = utils.ParseJSON(&story, resp.Body)
|
||||
if err != nil {
|
||||
return story, err
|
||||
}
|
||||
|
||||
@@ -40,7 +40,7 @@ func (widget *Widget) Create(jenkinsURL string, username string, apiKey string)
|
||||
return view, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(view, resp.Body)
|
||||
err = utils.ParseJSON(view, resp.Body)
|
||||
if err != nil {
|
||||
return view, err
|
||||
}
|
||||
|
||||
@@ -38,7 +38,7 @@ func (widget *Widget) IssuesFor(username string, projects []string, jql string)
|
||||
}
|
||||
|
||||
searchResult := &SearchResult{}
|
||||
err = utils.ParseJson(searchResult, resp.Body)
|
||||
err = utils.ParseJSON(searchResult, resp.Body)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
@@ -11,6 +11,7 @@ func Test_generateTitle(t *testing.T) {
|
||||
title string
|
||||
namespaces []string
|
||||
}
|
||||
|
||||
testCases := []struct {
|
||||
name string
|
||||
fields fields
|
||||
@@ -46,6 +47,7 @@ func Test_generateTitle(t *testing.T) {
|
||||
want: "Test Explicit Title",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range testCases {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
widget := &Widget{
|
||||
|
||||
@@ -18,7 +18,7 @@ func CurrentActiveItems(accessToken, assignedToName string, activeOnly bool) (*A
|
||||
return items, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&items, resp.Body)
|
||||
err = utils.ParseJSON(&items, resp.Body)
|
||||
|
||||
return items, nil
|
||||
}
|
||||
|
||||
@@ -33,7 +33,7 @@ func GetLinks(subreddit string, sortMode string, topTimePeriod string) ([]Link,
|
||||
return nil, fmt.Errorf(resp.Status)
|
||||
}
|
||||
var m RedditDocument
|
||||
err = utils.ParseJson(&m, resp.Body)
|
||||
err = utils.ParseJSON(&m, resp.Body)
|
||||
|
||||
if err != nil {
|
||||
return nil, err
|
||||
|
||||
@@ -26,7 +26,7 @@ func BuildsFor(settings *Settings) (*Builds, error) {
|
||||
return builds, err
|
||||
}
|
||||
|
||||
err = utils.ParseJson(&builds, resp.Body)
|
||||
err = utils.ParseJSON(&builds, resp.Body)
|
||||
if err != nil {
|
||||
return builds, err
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user