taigrr/wtf
1
0
Fork 0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00
Code Issues Projects Releases Wiki Activity

20191215 code improvements (#790)

Browse Source 
* Upgrade godo to latest
* Fix a bunch of issues found by
* Running staticcheck on a codebase for the first time is a sobering experience
* go mod tidy
* More static improvements

Signed-off-by: Chris Cummer <chriscummer@me.com>
This commit is contained in:
Chris Cummer
2019-12-16 20:25:29 -08:00
committed by GitHub
parent e71038ccf2
commit 3a388fba23
65 changed files with 236 additions and 815 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/opsgenie/client.go
View File

@@ -34,10 +34,10 @@ var opsGenieAPIUrl = map[string]string{
func (widget *Widget) Fetch(scheduleIdentifierType string, schedules []string) ([]*OnCallResponse, error) {
agregatedResponses := []*OnCallResponse{}
if regionUrl, regionErr := opsGenieAPIUrl[widget.settings.region]; regionErr {
if regionURL, regionErr := opsGenieAPIUrl[widget.settings.region]; regionErr {
for _, sched := range schedules {
scheduleUrl := fmt.Sprintf("%s/v2/schedules/%s/on-calls?scheduleIdentifierType=%s&flat=true", regionUrl, sched, scheduleIdentifierType)
response, err := opsGenieRequest(scheduleUrl, widget.settings.apiKey)
scheduleURL := fmt.Sprintf("%s/v2/schedules/%s/on-calls?scheduleIdentifierType=%s&flat=true", regionURL, sched, scheduleIdentifierType)
response, err := opsGenieRequest(scheduleURL, widget.settings.apiKey)
agregatedResponses = append(agregatedResponses, response)
if err != nil {
return nil, err
@@ -45,7 +45,7 @@ func (widget *Widget) Fetch(scheduleIdentifierType string, schedules []string) (
}
return agregatedResponses, nil
} else {
return nil, fmt.Errorf("You specified wrong region. Possible options are only 'us' and 'eu'.")
return nil, fmt.Errorf("you specified wrong region. Possible options are only 'us' and 'eu'")
}
}

2
modules/opsgenie/widget.go
View File

@@ -48,7 +48,7 @@ func (widget *Widget) content() (string, string, bool) {
} else {
for _, data := range onCallResponses {
if (len(data.OnCallData.Recipients) == 0) && (widget.settings.displayEmpty == false) {
if (len(data.OnCallData.Recipients) == 0) && !widget.settings.displayEmpty {
continue
}