20191215 code improvements (#790)

* Upgrade godo to latest
* Fix a bunch of issues found by
* Running staticcheck on a codebase for the first time is a sobering experience
* go mod tidy
* More static improvements

Signed-off-by: Chris Cummer <chriscummer@me.com>

modules/transmission/display.go

@@ -22,14 +22,13 @@ func (widget *Widget) content() (string, string, bool) {
 		return title, widget.err.Error(), true
 	}
 
-	data := widget.torrents
-	if data == nil || len(data) == 0 {
+	if len(widget.torrents) == 0 {
 		return title, "No data", false
 	}
 
 	str := ""
 
-	for idx, torrent := range data {
+	for idx, torrent := range widget.torrents {
 		torrName := *torrent.Name
 
 		row := fmt.Sprintf(

modules/transmission/widget.go

@@ -45,9 +45,6 @@ func NewWidget(app *tview.Application, pages *tview.Pages, settings *Settings) *
 
 // Fetch retrieves torrent data from the Transmission daemon
 func (widget *Widget) Fetch() ([]*transmissionrpc.Torrent, error) {
-	widget.mu.Lock()
-	widget.mu.Unlock()
-
 	if widget.client == nil {
 		return nil, errors.New("client was not initialized")
 	}