20191215 code improvements (#790)

* Upgrade godo to latest
* Fix a bunch of issues found by
* Running staticcheck on a codebase for the first time is a sobering experience
* go mod tidy
* More static improvements

Signed-off-by: Chris Cummer <chriscummer@me.com>

utils/text.go

@@ -63,7 +63,7 @@ func Truncate(src string, maxLen int, withEllipse bool) string {
 	for idx := range src {
 		runeCount++
 		if runeCount > maxLen {
-			if withEllipse == true {
+			if withEllipse {
 				return src[:idx-1] + "…"
 			}
 

utils/utils.go

@@ -92,10 +92,10 @@ func OpenFile(path string) {
 	if (strings.HasPrefix(path, "http://")) || (strings.HasPrefix(path, "https://")) {
 		if len(OpenUrlUtil) > 0 {
 			commands := append(OpenUrlUtil, path)
-			args := commands[1:len(commands)]
-			exec.Command(commands[0], args...).Start()
+			exec.Command(commands[0], commands[1:]...).Start()
 			return
 		}
+
 		switch runtime.GOOS {
 		case "linux":
 			exec.Command("xdg-open", path).Start()