diff --git a/modules/buildkite/client.go b/modules/buildkite/client.go index 22b1133f..dfb71810 100644 --- a/modules/buildkite/client.go +++ b/modules/buildkite/client.go @@ -57,6 +57,8 @@ func (widget *Widget) recentBuilds(pipeline PipelineSettings) ([]Build, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() + if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) } diff --git a/modules/finnhub/client.go b/modules/finnhub/client.go index 45dd7c7c..cd243665 100644 --- a/modules/finnhub/client.go +++ b/modules/finnhub/client.go @@ -70,6 +70,7 @@ func (client *Client) finnhubRequest(symbol string) (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/football/client.go b/modules/football/client.go index aaf48548..944081fb 100644 --- a/modules/football/client.go +++ b/modules/football/client.go @@ -41,5 +41,7 @@ func (client *Client) footballRequest(path string, id int) (*http.Response, erro if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() + return resp, nil } diff --git a/modules/gitter/client.go b/modules/gitter/client.go index eb6397e3..3341fac2 100644 --- a/modules/gitter/client.go +++ b/modules/gitter/client.go @@ -66,6 +66,7 @@ func apiRequest(path, apiToken string) (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/hackernews/client.go b/modules/hackernews/client.go index 85d4f0c9..91034e83 100644 --- a/modules/hackernews/client.go +++ b/modules/hackernews/client.go @@ -61,6 +61,7 @@ func apiRequest(path string) (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/jenkins/client.go b/modules/jenkins/client.go index 5fcbb6da..04c32389 100644 --- a/modules/jenkins/client.go +++ b/modules/jenkins/client.go @@ -39,6 +39,7 @@ func (widget *Widget) Create(jenkinsURL string, username string, apiKey string) if err != nil { return view, err } + defer func() { _ = resp.Body.Close() }() err = utils.ParseJSON(view, resp.Body) if err != nil { diff --git a/modules/jira/client.go b/modules/jira/client.go index b59cb19c..287cb459 100644 --- a/modules/jira/client.go +++ b/modules/jira/client.go @@ -72,6 +72,7 @@ func (widget *Widget) jiraRequest(path string) (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/rollbar/client.go b/modules/rollbar/client.go index b008fa7d..bf581c4e 100644 --- a/modules/rollbar/client.go +++ b/modules/rollbar/client.go @@ -50,6 +50,7 @@ func rollbarItemRequest(accessToken, assignedToName string, activeOnly bool) (*h if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/subreddit/api.go b/modules/subreddit/api.go index c9edc191..8ac90082 100644 --- a/modules/subreddit/api.go +++ b/modules/subreddit/api.go @@ -28,6 +28,7 @@ func GetLinks(subreddit string, sortMode string, topTimePeriod string) ([]Link, if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/travisci/client.go b/modules/travisci/client.go index de696992..86cc1810 100644 --- a/modules/travisci/client.go +++ b/modules/travisci/client.go @@ -67,6 +67,7 @@ func travisBuildRequest(settings *Settings) (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode < 200 || resp.StatusCode > 299 { return nil, fmt.Errorf(resp.Status) diff --git a/modules/uptimerobot/widget.go b/modules/uptimerobot/widget.go index 9d3d4266..0f4636d8 100644 --- a/modules/uptimerobot/widget.go +++ b/modules/uptimerobot/widget.go @@ -158,6 +158,7 @@ func (widget *Widget) getMonitors() ([]Monitor, error) { if errh != nil { return nil, errh } + defer func() { _ = resp.Body.Close() }() body, _ := ioutil.ReadAll(resp.Body) diff --git a/modules/weatherservices/arpansagovau/client.go b/modules/weatherservices/arpansagovau/client.go index b850b22f..b68e0fd8 100644 --- a/modules/weatherservices/arpansagovau/client.go +++ b/modules/weatherservices/arpansagovau/client.go @@ -65,6 +65,7 @@ func apiRequest() (*http.Response, error) { if err != nil { return nil, err } + defer func() { _ = resp.Body.Close() }() if resp.StatusCode != 200 { return nil, fmt.Errorf(resp.Status)