1
0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00

golangci-lint configuration file

golangci-lint can run all the currently enabled linters, and as far as I
can tell, does it in under 5 seconds as opposed to over 180 seconds
(compare `time make cilint` and `time make lint`).

Some of the linters that are listed in the "enabled" section but
commented out looked like a good idea to me, and fairly low hanging
fruit to fix, but they are not passing at the moment.

All the linters covered in the current Makefile are run.

TODO:
- replace lint target in Makefile with golangci-lint
- remove .github/workflow/errcheck.yml
This commit is contained in:
Sam Roberts
2020-05-16 11:59:24 -07:00
parent e43c37cc07
commit 4bb725db9e
23 changed files with 84 additions and 41 deletions

View File

@@ -200,7 +200,7 @@ func (tracker *FocusTracker) focusables() []wtf.Wtfable {
}
// Sort for deterministic ordering
sort.SliceStable(focusable[:], func(i, j int) bool {
sort.SliceStable(focusable, func(i, j int) bool {
iTop := focusable[i].CommonSettings().Top
jTop := focusable[j].CommonSettings().Top

View File

@@ -109,6 +109,7 @@ func (wtfApp *WtfApp) keyboardIntercept(event *tcell.EventKey) *tcell.EventKey {
switch string(event.Rune()) {
case "/":
return nil
default:
}
}