1
0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00

golangci-lint configuration file

golangci-lint can run all the currently enabled linters, and as far as I
can tell, does it in under 5 seconds as opposed to over 180 seconds
(compare `time make cilint` and `time make lint`).

Some of the linters that are listed in the "enabled" section but
commented out looked like a good idea to me, and fairly low hanging
fruit to fix, but they are not passing at the moment.

All the linters covered in the current Makefile are run.

TODO:
- replace lint target in Makefile with golangci-lint
- remove .github/workflow/errcheck.yml
This commit is contained in:
Sam Roberts
2020-05-16 11:59:24 -07:00
parent e43c37cc07
commit 4bb725db9e
23 changed files with 84 additions and 41 deletions

View File

@@ -13,7 +13,7 @@ const AM = "A"
const PM = "P"
const minRowsForBorder = 3
// Converts integer to string along with makes sure the lenght of string is > 2
// Converts integer to string along with makes sure the length of string is > 2
func intStrConv(val int) string {
valStr := strconv.Itoa(val)
@@ -39,9 +39,9 @@ func getHourMinute(hourFormat string) string {
}
strMintues := intStrConv(time.Now().Minute())
strMintues = strMintues + AMPM
return strHours + getColon() + strMintues
strMinutes := intStrConv(time.Now().Minute())
strMinutes += AMPM
return strHours + getColon() + strMinutes
}
// Returns the : with blinking based on the seconds

View File

@@ -3,7 +3,7 @@ package digitalclock
import "strings"
func mergeLines(outString []string) string {
return strings.Join(outString[:], "\n")
return strings.Join(outString, "\n")
}
func renderWidget(widgetSettings Settings) string {