1
0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00

golangci-lint configuration file

golangci-lint can run all the currently enabled linters, and as far as I
can tell, does it in under 5 seconds as opposed to over 180 seconds
(compare `time make cilint` and `time make lint`).

Some of the linters that are listed in the "enabled" section but
commented out looked like a good idea to me, and fairly low hanging
fruit to fix, but they are not passing at the moment.

All the linters covered in the current Makefile are run.

TODO:
- replace lint target in Makefile with golangci-lint
- remove .github/workflow/errcheck.yml
This commit is contained in:
Sam Roberts
2020-05-16 11:59:24 -07:00
parent e43c37cc07
commit 4bb725db9e
23 changed files with 84 additions and 41 deletions

View File

@@ -178,7 +178,7 @@ func (client *Client) GetAccessToken(requestToken string) (accessToken string, e
}
/*LinkState represents links states to be retrived
/*LinkState represents link states to be retrieved
According to the api https://getpocket.com/developer/docs/v3/retrieve
there are 3 states:
1-archive
@@ -197,7 +197,7 @@ const (
Unread LinkState = "unread"
)
// GetLinks retrive links of a given states https://getpocket.com/developer/docs/v3/retrieve
// GetLinks retrieve links of a given states https://getpocket.com/developer/docs/v3/retrieve
func (client *Client) GetLinks(state LinkState) (response ItemLists, err error) {
url := fmt.Sprintf("%s/get?sort=newest&state=%s&consumer_key=%s&access_token=%s", client.baseURL, state, client.consumerKey, *client.accessToken)
req := request{