1
0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00

WTF-315 Fix race conditions caused by writing to view

This commit is contained in:
Chris Cummer
2019-04-24 23:53:31 -07:00
parent a1aae6206f
commit 5445309aa0
33 changed files with 256 additions and 96 deletions

View File

@@ -38,8 +38,10 @@ type Widget struct {
GerritProjects []*GerritProject
Idx int
selected int
settings *Settings
app *tview.Application
selected int
settings *Settings
}
var (
@@ -51,7 +53,9 @@ func NewWidget(app *tview.Application, pages *tview.Pages, settings *Settings) *
HelpfulWidget: wtf.NewHelpfulWidget(app, pages, HelpText),
TextWidget: wtf.NewTextWidget(app, settings.common, true),
Idx: 0,
Idx: 0,
app: app,
settings: settings,
}
@@ -91,8 +95,11 @@ func (widget *Widget) Refresh() {
gerrit, err := glb.NewClient(gerritUrl, httpClient)
if err != nil {
widget.View.SetWrap(true)
widget.View.SetTitle(widget.Name())
widget.View.SetText(err.Error())
widget.app.QueueUpdateDraw(func() {
widget.View.SetTitle(widget.Name())
widget.View.SetText(err.Error())
})
return
}
widget.gerrit = gerrit
@@ -102,7 +109,10 @@ func (widget *Widget) Refresh() {
project.Refresh(widget.settings.username)
}
widget.display()
widget.app.QueueUpdateDraw(func() {
widget.View.SetTitle(widget.Name())
widget.display()
})
}
/* -------------------- Unexported Functions -------------------- */