From aae1cf55cca5d5df1da07e6e74052940917085fe Mon Sep 17 00:00:00 2001 From: David Bouchare Date: Sun, 22 Nov 2020 03:21:02 +0100 Subject: [PATCH] [CircleCI] Add configurable number of builds to settings (#1025) * Add configurable build number to settings * Review feedback: number of builds --- modules/circleci/settings.go | 6 ++++-- modules/circleci/widget.go | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/circleci/settings.go b/modules/circleci/settings.go index e6f13bc8..d46c82b3 100644 --- a/modules/circleci/settings.go +++ b/modules/circleci/settings.go @@ -15,7 +15,8 @@ const ( type Settings struct { common *cfg.Common - apiKey string `help:"Your CircleCI API token."` + apiKey string `help:"Your CircleCI API token."` + numberOfBuilds int `help:"The number of build, 10 by default"` } func NewSettingsFromYAML(name string, ymlConfig *config.Config, globalConfig *config.Config) *Settings { @@ -23,7 +24,8 @@ func NewSettingsFromYAML(name string, ymlConfig *config.Config, globalConfig *co settings := Settings{ common: cfg.NewCommonSettingsFromModule(name, defaultTitle, defaultFocusable, ymlConfig, globalConfig), - apiKey: ymlConfig.UString("apiKey", ymlConfig.UString("apikey", os.Getenv("WTF_CIRCLE_API_KEY"))), + apiKey: ymlConfig.UString("apiKey", ymlConfig.UString("apikey", os.Getenv("WTF_CIRCLE_API_KEY"))), + numberOfBuilds: ymlConfig.UInt("numberOfBuilds", 10), } cfg.ModuleSecret(name, globalConfig, &settings.apiKey).Load() diff --git a/modules/circleci/widget.go b/modules/circleci/widget.go index de06a2cd..e9ec1f8e 100644 --- a/modules/circleci/widget.go +++ b/modules/circleci/widget.go @@ -48,7 +48,7 @@ func (widget *Widget) content() (string, string, bool) { str = err.Error() } else { for idx, build := range builds { - if idx > 10 { + if idx > widget.settings.numberOfBuilds { break }