From ddfc439c418f5e5e35a9104f04a4c374f1ce7497 Mon Sep 17 00:00:00 2001 From: Fredrik Steen Date: Wed, 20 Jan 2021 18:03:27 +0100 Subject: [PATCH] Fix for potential runtime panic (#1046) Switch error checking around, so we don't check the StatusCode before handling client errors. --- modules/healthchecks/widget.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/healthchecks/widget.go b/modules/healthchecks/widget.go index e2400d9e..f8a7f2db 100644 --- a/modules/healthchecks/widget.go +++ b/modules/healthchecks/widget.go @@ -165,13 +165,14 @@ func (widget *Widget) getExistingChecks() ([]Checks, error) { req.Header.Set("X-Api-Key", widget.settings.apiKey) resp, err := http.DefaultClient.Do(req) + if err != nil { + return nil, err + } + if resp.StatusCode != 200 { return nil, fmt.Errorf(resp.Status) } - if err != nil { - return nil, err - } defer func() { _ = resp.Body.Close() }() var health Health