taigrr/wtf
1
0
Fork 0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00
Code Issues Projects Releases Wiki Activity

Some code improvements

Browse Source 
* Some assignments simplified by using assignment operators
* Rewrite switch statement with only one case as if.
* Rewrite if-else chain as a switch statement.
* go fmt `modules/todoist/project.go` file.
This commit is contained in:
Kirill Motkov
2019-05-21 17:17:47 +03:00
parent c050292a8d
commit f0771cd013
46 changed files with 161 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
modules/gitlab/display.go
View File

@@ -16,14 +16,14 @@ func (widget *Widget) display() {
_, _, width, _ := widget.View.GetRect()
str := widget.settings.common.SigilStr(len(widget.GitlabProjects), widget.Idx, width) + "\n"
str = str + " [red]Stats[white]\n"
str = str + widget.displayStats(project)
str = str + "\n"
str = str + " [red]Open Approval Requests[white]\n"
str = str + widget.displayMyApprovalRequests(project, widget.settings.username)
str = str + "\n"
str = str + " [red]My Merge Requests[white]\n"
str = str + widget.displayMyMergeRequests(project, widget.settings.username)
str += " [red]Stats[white]\n"
str += widget.displayStats(project)
str += "\n"
str += " [red]Open Approval Requests[white]\n"
str += widget.displayMyApprovalRequests(project, widget.settings.username)
str += "\n"
str += " [red]My Merge Requests[white]\n"
str += widget.displayMyMergeRequests(project, widget.settings.username)
widget.Redraw(title, str, false)
}
@@ -36,7 +36,7 @@ func (widget *Widget) displayMyMergeRequests(project *GitlabProject, username st
str := ""
for _, mr := range mrs {
str = str + fmt.Sprintf(" [green]%4d[white] %s\n", mr.IID, mr.Title)
str += fmt.Sprintf(" [green]%4d[white] %s\n", mr.IID, mr.Title)
}
return str
@@ -51,7 +51,7 @@ func (widget *Widget) displayMyApprovalRequests(project *GitlabProject, username
str := ""
for _, mr := range mrs {
str = str + fmt.Sprintf(" [green]%4d[white] %s\n", mr.IID, mr.Title)
str += fmt.Sprintf(" [green]%4d[white] %s\n", mr.IID, mr.Title)
}
return str

4
modules/gitlab/widget.go
View File

@@ -56,7 +56,7 @@ func (widget *Widget) Refresh() {
}
func (widget *Widget) Next() {
widget.Idx = widget.Idx + 1
widget.Idx++
if widget.Idx == len(widget.GitlabProjects) {
widget.Idx = 0
}
@@ -65,7 +65,7 @@ func (widget *Widget) Next() {
}
func (widget *Widget) Prev() {
widget.Idx = widget.Idx - 1
widget.Idx--
if widget.Idx < 0 {
widget.Idx = len(widget.GitlabProjects) - 1
}