taigrr/wtf
1
0
Fork 0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00
Code Issues Projects Releases Wiki Activity

Some code improvements

Browse Source 
* Some assignments simplified by using assignment operators
* Rewrite switch statement with only one case as if.
* Rewrite if-else chain as a switch statement.
* go fmt `modules/todoist/project.go` file.
This commit is contained in:
Kirill Motkov
2019-05-21 17:17:47 +03:00
parent c050292a8d
commit f0771cd013
46 changed files with 161 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
modules/pagerduty/widget.go
View File

@@ -48,10 +48,10 @@ func (widget *Widget) Refresh() {
if err1 != nil || err2 != nil {
wrap = true
if err1 != nil {
content = content + err1.Error()
content += err1.Error()
}
if err2 != nil {
content = content + err2.Error()
content += err2.Error()
}
} else {
widget.View.SetWrap(false)
@@ -67,12 +67,12 @@ func (widget *Widget) contentFrom(onCalls []pagerduty.OnCall, incidents []pagerd
var str string
if len(incidents) > 0 {
str = str + "[yellow]Incidents[white]\n"
str += "[yellow]Incidents[white]\n"
for _, incident := range incidents {
str = str + fmt.Sprintf("[red]%s[white]\n", incident.Summary)
str = str + fmt.Sprintf("Status: %s\n", incident.Status)
str = str + fmt.Sprintf("Service: %s\n", incident.Service.Summary)
str = str + fmt.Sprintf("Escalation: %s\n", incident.EscalationPolicy.Summary)
str += fmt.Sprintf("[red]%s[white]\n", incident.Summary)
str += fmt.Sprintf("Status: %s\n", incident.Status)
str += fmt.Sprintf("Service: %s\n", incident.Service.Summary)
str += fmt.Sprintf("Escalation: %s\n", incident.EscalationPolicy.Summary)
}
}
@@ -99,14 +99,14 @@ func (widget *Widget) contentFrom(onCalls []pagerduty.OnCall, incidents []pagerd
sort.Strings(keys)
if len(keys) > 0 {
str = str + "\n[red] Schedules[white]\n"
str += "\n[red] Schedules[white]\n"
// Print out policies, and escalation order of users
for _, key := range keys {
str = str + fmt.Sprintf("\n [green::b]%s\n", key)
str += fmt.Sprintf("\n [green::b]%s\n", key)
values := tree[key]
sort.Sort(ByEscalationLevel(values))
for _, item := range values {
str = str + fmt.Sprintf(" [white]%d - %s\n", item.EscalationLevel, item.User.Summary)
str += fmt.Sprintf(" [white]%d - %s\n", item.EscalationLevel, item.User.Summary)
}
}
}