1
0
mirror of https://github.com/taigrr/wtf synced 2025-01-18 04:03:14 -08:00

Remove the app.Draw() gorountine

Prefer to have widgets force a draw when their data changes. This should
reduce draws (unless the user has a module installed that updates >=
1/sec, the old draw default).

This should also remove a source of some of the race conditions that
users were experiencing (though not all, there are still many).
This commit is contained in:
Chris Cummer
2018-09-24 14:32:36 -07:00
parent 9bd2430063
commit f650bb1698
41 changed files with 135 additions and 121 deletions

View File

@@ -23,7 +23,7 @@ type TextWidget struct {
Position
}
func NewTextWidget(name string, configKey string, focusable bool) TextWidget {
func NewTextWidget(app *tview.Application, name string, configKey string, focusable bool) TextWidget {
widget := TextWidget{
enabled: Config.UBool(fmt.Sprintf("wtf.mods.%s.enabled", configKey), false),
focusable: focusable,
@@ -39,7 +39,7 @@ func NewTextWidget(name string, configKey string, focusable bool) TextWidget {
Config.UInt(fmt.Sprintf("wtf.mods.%s.position.height", configKey)),
)
widget.addView()
widget.addView(app)
return widget
}
@@ -96,12 +96,15 @@ func (widget *TextWidget) TextView() *tview.TextView {
/* -------------------- Unexported Functions -------------------- */
func (widget *TextWidget) addView() {
func (widget *TextWidget) addView(app *tview.Application) {
view := tview.NewTextView()
view.SetBackgroundColor(colorFor(Config.UString("wtf.colors.background", "black")))
view.SetBorder(true)
view.SetBorderColor(colorFor(widget.BorderColor()))
view.SetChangedFunc(func() {
app.Draw()
})
view.SetDynamicColors(true)
view.SetTitle(widget.ContextualTitle(widget.Name))
view.SetWrap(false)