From fe5842e5f9ce3350e3253113a74a235aa8d9f519 Mon Sep 17 00:00:00 2001 From: Mike Farah Date: Tue, 27 Aug 2019 09:21:39 +1000 Subject: [PATCH] Fix: Only remove original file if copying was successful --- yq.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/yq.go b/yq.go index 458ca6e..549cfbc 100644 --- a/yq.go +++ b/yq.go @@ -633,11 +633,12 @@ func safelyRenameFile(from string, to string) { if copyError := copyFileContents(from, to); copyError != nil { log.Errorf("Failed copying from %v to %v", from, to) log.Error(copyError.Error()) + } else { + removeErr := os.Remove(from) + if removeErr != nil { + log.Errorf("failed removing original file: %s", from) + } } - removeErr := os.Remove(from) - if removeErr != nil { - log.Errorf("failed removing original file: %s", from) - } } }