[IMPROVED] $SYS.REQ.SERVER.PING.PROFILEZ always honored (#4393)

This commit is contained in:
Neil
2023-08-14 22:03:46 +01:00
committed by GitHub
3 changed files with 3 additions and 13 deletions

View File

@@ -3657,11 +3657,6 @@ type ProfilezStatus struct {
}
func (s *Server) profilez(opts *ProfilezOptions) *ProfilezStatus {
if s.profiler == nil {
return &ProfilezStatus{
Error: "Profiling is not enabled",
}
}
if opts.Name == _EMPTY_ {
return &ProfilezStatus{
Error: "Profile name not specified",

View File

@@ -4647,14 +4647,6 @@ func TestMonitorProfilez(t *testing.T) {
s := RunServer(DefaultOptions())
defer s.Shutdown()
// First of all, check that the profiles aren't accessible
// when profiling hasn't been started in the usual way.
if ps := s.profilez(&ProfilezOptions{
Name: "allocs", Debug: 0,
}); ps.Error == "" {
t.Fatal("Profile should not be accessible when profiling not started")
}
// Then start profiling.
s.StartProfiler()

View File

@@ -2093,6 +2093,9 @@ func (s *Server) Start() {
// Pprof http endpoint for the profiler.
if opts.ProfPort != 0 {
s.StartProfiler()
} else {
// Enable blocking profile even if no port defined since profiling is always possible over $SYS requests
runtime.SetBlockProfileRate(1)
}
if opts.ConfigFile != _EMPTY_ {