gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-16 19:14:41 -07:00
Code Issues Packages Projects Releases Wiki Activity

[Fixed] race on unlocked cfg access (#3223)

Browse Source 
write originated in updateWithAdvisory while holding the lock

Signed-off-by: Matthias Hanel <mh@synadia.com>
This commit is contained in:
Matthias Hanel
2022-06-29 00:05:00 +02:00
committed by GitHub
parent 10e1d055a8
commit dff1a33693
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/jetstream_cluster.go
View File

@@ -1844,7 +1844,9 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment, sendSnaps
if len(ci.Replicas)+1 != len(rg.Peers) {
continue
}
mset.mu.RLock()
replicas := mset.cfg.Replicas
mset.mu.RUnlock()
if len(rg.Peers) <= replicas {
stopMigrationMonitoring()
continue
@@ -1874,7 +1876,7 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment, sendSnaps
}
}
// If all are current we are good, or if we have some offline and we have a quorum.
if quorum := mset.cfg.Replicas/2 + 1; currentCount >= quorum {
if quorum := replicas/2 + 1; currentCount >= quorum {
stopMigrationMonitoring()
// Remove the old peers and transfer leadership.
time.AfterFunc(2*time.Second, func() { js.removeOldPeers(mset, firstPeer, newPeerSet) })