gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix data race in setStreamAssignment by ensuring JS lock held (#4559)

Browse Source 
`addStreamWithAssignment` did not hold the JS lock at the point of
calling `setStreamAssignment`, which could result in a data race
accessing the Raft group peers from the stream assignment on line 774.

Signed-off-by: Neil Twigg <neil@nats.io>
This commit is contained in:
Neil
2023-09-19 18:09:49 +01:00
committed by GitHub
parent 3dc0627811 887b92bfe2
commit f6268fd7c8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/stream.go
View File

@@ -747,6 +747,7 @@ func (mset *stream) streamAssignment() *streamAssignment {
func (mset *stream) setStreamAssignment(sa *streamAssignment) {
var node RaftNode
var peers []string
mset.mu.RLock()
js := mset.js
@@ -756,6 +757,7 @@ func (mset *stream) setStreamAssignment(sa *streamAssignment) {
js.mu.RLock()
if sa.Group != nil {
node = sa.Group.node
peers = sa.Group.Peers
}
js.mu.RUnlock()
}
@@ -771,7 +773,7 @@ func (mset *stream) setStreamAssignment(sa *streamAssignment) {
// Set our node.
mset.node = node
if mset.node != nil {
mset.node.UpdateKnownPeers(sa.Group.Peers)
mset.node.UpdateKnownPeers(peers)
}
// Setup our info sub here as well for all stream members. This is now by design.