4276 Commits

Author SHA1 Message Date
Jaime Piña
fd0f714d09 Consolidate test running logic
Currently, we have different commands to run tests spread across
different YAML files and comments in Go files.

This change consolidates all the different commands, environment
variables, and OS limits into 1 file that Travis, GitHub, and engineers
can use to run tests.
2021-04-12 11:33:14 -07:00
Derek Collison
c63f1d78b2 Merge pull request #2104 from nats-io/pbug2
Make sure we do not set last to -1
2021-04-12 11:19:09 -07:00
Derek Collison
bbb03af442 Make sure we do not set last to -1. #2068
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 11:01:41 -07:00
Waldemar Quevedo
a7db58c899 Merge pull request #2103 from wallyqs/sigterm-fix
Make TERM exit 1 as pre v2.2 series
2021-04-12 10:54:50 -07:00
Waldemar Quevedo
8daf6e4995 Make SIGTERM exit 1
Before 2.2 series, the TERM signal used to not be handled
by the server, so it would not have been a clean exit.
In 2.2, it was changed to process TERM signal as a clean exit
but this affects the behavior of some tools that were expecting
TERM to be exit 1.

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
2021-04-12 10:17:13 -07:00
Ivan Kozlovic
9d8ea6b64a Merge pull request #2102 from nats-io/fix_leafnode_flapper
Fixed leafnode flapper
2021-04-12 09:59:36 -06:00
Derek Collison
66b0c5c216 Merge pull request #2100 from nats-io/csz
Only adjust cluster size when we have heard from all peers.
2021-04-12 08:52:07 -07:00
Derek Collison
cb55e163a5 Merge pull request #2098 from nats-io/mixedmode
Add mixedmode test back in
2021-04-12 08:48:43 -07:00
Ivan Kozlovic
c369a26c03 Fixed leafnode flapper
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-12 09:31:33 -06:00
Derek Collison
32734960ed Merge pull request #2099 from nats-io/pbug
Partial fix for #2068
2021-04-11 10:46:48 -07:00
Derek Collison
0cee993e3b When checking cluster size we need to make sure we have heard from all peers before making adjustments.
Also check back periodically.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 15:55:51 -07:00
Derek Collison
e0eaf704dc Partial fix for #2068.
This will not protect against the index file being completely removed.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 12:46:31 -07:00
Derek Collison
2bc4bf19a7 Make sure to clean up directories
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 10:25:12 -07:00
Derek Collison
833279388b Add mixedmode test back in
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 10:10:37 -07:00
Derek Collison
69269c5653 Merge pull request #2095 from nats-io/mixed
Mixed mode improvements.
2021-04-09 16:56:41 -07:00
Derek Collison
27d8b939b5 Updated based on comments that the one fix was actually a misconfiguration.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-09 16:49:24 -07:00
Ivan Kozlovic
948d69ae7d Merge pull request #2096 from nats-io/gofmt-s
Run gofmt -s to simplify code
2021-04-09 17:27:39 -06:00
Jaime Piña
27e9628c3a Run gofmt -s to simplify code 2021-04-09 15:18:06 -07:00
Derek Collison
e438d2f5fa Mixed mode improvements.
1. When in mixed mode and only running the global account we now will check the account for JS.
2. Added code to decrease the cluster set size if we guessed wrong in mixed mode setup.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-09 14:58:35 -07:00
Matthias Hanel
da4430fc8d using clearTimer(&c.ping.tmr) for cleanup
Signed-off-by: Matthias Hanel <mh@synadia.com>
2021-04-09 16:53:06 -04:00
Matthias Hanel
f7a772f097 Ensure that leafNodeFinishConnectProcess is only executed once.
incorporate review comments

Signed-off-by: Matthias Hanel <mh@synadia.com>
2021-04-09 16:53:06 -04:00
Matthias Hanel
5d1f36dd17 [Fixed] leaf node subscription permission negotiation.
On connect all subscription where sent by the soliciting leaf node.
If creds contains sub deny permissions, the leaf node would be
disconnected.
This waits for the permissions to be exchanged and checks permissions
before sending subscriptions.

Signed-off-by: Matthias Hanel <mh@synadia.com>
2021-04-09 16:53:06 -04:00
Derek Collison
112257d09d Merge pull request #2089 from nats-io/flappers
Fix flappers
2021-04-09 08:54:24 -07:00
Derek Collison
3c051d461c Fix flappers
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-08 18:03:14 -07:00
Ivan Kozlovic
6fef6456e8 Merge pull request #2088 from nats-io/fix_leafnode_first_ping
[FIXED] LeafNode: set first ping timer after receiving CONNECT
2021-04-08 17:53:06 -06:00
Ivan Kozlovic
666eea5b95 Merge pull request #2087 from nats-io/fix_tmp_pid_file
Fixed expected pid path in options
2021-04-08 16:10:04 -06:00
Derek Collison
1c368973c8 Merge pull request #2086 from alexpantyukhin/fix_max_bytes_check_memstore
fix for memstore storeRawMsg be consistent with filestore
2021-04-08 14:48:56 -07:00
Ivan Kozlovic
a7e5853a3c Fixed expected pid path in options
This was introduced by PR #2071.

On some tests, options are loaded based on a config file that has
the pid set to "/tm/nats-server/nats-server.pid", however, the
expected option's pid path was set based on tmpRoot. The problem
is that on macOS, that value would be "/var/folders/xxx" which
would not match.
So this PR simply reverts the changes to the expected pid file
name: it simply needs to match was in the test.conf file.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-08 15:08:23 -06:00
Ivan Kozlovic
452685b9b1 [FIXED] LeafNode: set first ping timer after receiving CONNECT
We were setting the ping timer in the accepting server as soon
as the leafnode connection is created, just after sending
the INFO and setting the auth timer.

Sending a PING too soon may cause the solicit side to process
this PING and send a PONG in response, possibly before sending
the CONNECT, which the accepting side would fail as an authentication
error, since first protocol is expected to be a CONNECT.

Since LeafNode always expect a CONNECT, we always set the auth
timer. So now on accept, instead of starting the ping timer just
after sending the INFO, we will delay setting this timer only
after receiving the CONNECT.

The auth timer will take care of a stale connection in the time
it takes to receives the CONNECT.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-08 14:36:39 -06:00
alexpantyukhin
ce34266912 fix for memstore storeRawMsg be consistent with filestore 2021-04-08 23:54:10 +04:00
Derek Collison
7030b0eb46 Merge pull request #2085 from nats-io/ack_pending
Fix for #2083
2021-04-08 12:31:35 -07:00
Derek Collison
deb015ec73 Fix for #2083 to release ack pending when messages expire or hit max redeliveries.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-08 11:47:59 -07:00
Ivan Kozlovic
36e18c20ff Merge pull request #2084 from ripienaar/client_auth_kind
expose the connection kind to CustomClientAuthentication
2021-04-08 10:55:33 -06:00
R.I.Pienaar
f2d1a173db expose the connection kind to CustomClientAuthentication
Signed-off-by: R.I.Pienaar <rip@devco.net>
2021-04-08 18:33:55 +02:00
Ivan Kozlovic
c7f8296a85 Merge pull request #2065 from alexpantyukhin/extract_server_update
extract_server_update
2021-04-08 09:01:51 -06:00
alexpantyukhin
e16bebb8df extract update remote subscription. 2021-04-08 16:37:12 +04:00
Derek Collison
6024c85c09 Bump to 2.2.2-beta
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-07 17:44:30 -07:00
Derek Collison
a5440f4ae7 Merge pull request #2080 from nats-io/compact_bug
Fix bug that could cause panic and corruption on filestore compact.
2021-04-07 15:38:42 -07:00
Derek Collison
16941c78a0 Merge pull request #2076 from nats-io/account_load
Report an error if we fail to load an account on a stream assignment.
2021-04-07 14:40:27 -07:00
Derek Collison
98f099002d Merge pull request #2081 from nats-io/quiet_race
Quiet race detector
2021-04-07 14:40:02 -07:00
Derek Collison
bfb482121d In some scenarios compact could count messages it should not and make mb.msgs go negative which meant max uint64.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-07 14:39:23 -07:00
Derek Collison
2bea1f64f5 Merge pull request #2078 from nats-io/mirror_panic
If a mirror was removed or changed this would panic.
2021-04-07 14:26:56 -07:00
Derek Collison
1b5f0edbab Quiet race detector
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-07 14:25:21 -07:00
Derek Collison
1ea4a430da If we fail to load an account while processing a stream assignment, send error back to metaleader.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-07 14:23:12 -07:00
Derek Collison
74a051e3a8 Merge pull request #2075 from nats-io/startup
Optimize startup for filtered consumers when creating pending count.
2021-04-07 14:16:32 -07:00
Ivan Kozlovic
30001284ba Merge pull request #2072 from nats-io/websocket_tls_reload
[FIXED] Websocket: TLS configuration not updated on reload
2021-04-07 15:16:15 -06:00
Ivan Kozlovic
f96f36c73d [FIXED] Websocket: TLS configuration not updated on reload
Although we do not support websocket configuration changes, we usually
try to support changes to TLS certificates, etc..

The way websocket is handled (using an http server), the TLS config
was given on startup and updates following a configuration reload
would not be reflected.
Using a tls.Config function that allows passing the tls config
prior to handshake seem to workaround this issue.

I have added a test that demonstrate that the TLS configuration
is really updated after the reload.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-07 13:58:35 -06:00
Ivan Kozlovic
cdbe3f041f Merge pull request #2079 from nats-io/check-fs-errs
Check errors when removing test directories and files
2021-04-07 13:55:40 -06:00
Jaime Piña
d929ee1348 Check errors when removing test directories and files
Currently in tests, we have calls to os.Remove and os.RemoveAll where we
don't check the returned error. This hides useful error messages when
tests fail to run, such as "too many open files".

This change checks for more filesystem related errors and calls t.Fatal
if there is an error.
2021-04-07 11:09:47 -07:00
Derek Collison
114431bb3c If a mirror config was removed the reference to mset.mirror.msgs would fail.
This protects against that.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-07 10:59:05 -07:00